Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isObject to work with classes #12

Merged
merged 2 commits into from Mar 3, 2018
Merged

Fix isObject to work with classes #12

merged 2 commits into from Mar 3, 2018

Conversation

kurtcorbett
Copy link
Contributor

@kurtcorbett kurtcorbett commented Mar 2, 2018 •
edited by mesaugat

isObject implementation based off of this Stack overflow response.

closes #13

@kurtcorbett kurtcorbett mentioned this pull request Mar 2, 2018
Closed
@mesaugat mesaugat self-requested a review March 3, 2018 03:29
@mesaugat mesaugat added the bug label Mar 3, 2018
mesaugat
mesaugat approved these changes Mar 3, 2018
View reviewed changes
Copy link
Owner

@mesaugat mesaugat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@mesaugat mesaugat changed the title fix #isObject to work with classes Fix isObject to work with classes Mar 3, 2018
@mesaugat mesaugat merged commit e49a916 into mesaugat:master Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesaugat mesaugat mesaugat approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Classes are being returned as empty arrays
2 participants
@kurtcorbett @mesaugat