Forward returned value from assertEqual #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaptainAchab
pushed a commit
to TankerHQ/sdk-js
that referenced
this pull request
Aug 18, 2021
Waiting for this PR to be merged mesaugat/chai-exclude#37
|
Published in version |
CaptainAchab
pushed a commit
to TankerHQ/sdk-js
that referenced
this pull request
Sep 24, 2021
Our patch has been merged and released mesaugat/chai-exclude#37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use chai-exclude and chai-as-promised in our project. With chai-as-promised, assertions return promises, for example:
But chai-exclude drops the promise because it doesn't forward the return value of the parent assertEqual(). This PR fixes it.