New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename service id to hash #626

Closed

NicolasMahe wants to merge 16 commits into dev from feature/rename-service-ID-and-alias

Member

NicolasMahe commented Dec 6, 2018 •

edited

Loading

Depend on #627
Second half of #625

NicolasMahe added 2 commits

December 6, 2018 18:35


          Rename ID by Hash

7573fa1


          Generate assets, proto, mocks

73517c5

NicolasMahe self-assigned this

NicolasMahe added 2 commits

December 6, 2018 18:55


          Fix rename

dd92d02


          Fix test and lint

3851e72

NicolasMahe changed the base branch from dev to feature/rename-alias-to-sid

December 6, 2018 13:58


          Merge branch 'feature/rename-alias-to-sid' into feature/rename-servic…

d78901d

…e-ID-and-alias

NicolasMahe changed the title ~~[WIP] Rename service id and alias~~ [WIP] Rename service id to hash

Member Author

NicolasMahe commented Dec 6, 2018 •

edited

Loading

This PR introduces one change on the api:
https://github.com/mesg-foundation/core/pull/626/files#diff-3ec4078a2b83ce9f8a52b41a8f1f4397R476

-  string ID = 10;                           // Service's unique id service hash.
+  string Hash = 10;                           // Service's unique id service hash.

@ilgooz @krhubert I wonder if it's a breaking change. The type, and the number are the same. Only the name change. What do you think?


          Merge branch 'feature/rename-alias-to-sid' into feature/rename-servic…

75f6341

…e-ID-and-alias

NicolasMahe requested review from ilgooz, krhubert and antho1404

December 6, 2018 14:18

NicolasMahe changed the title ~~[WIP] Rename service id to hash~~ Rename service id to hash

Contributor

ilgooz commented Dec 6, 2018 •

edited

Loading

This PR introduces one change on the api:
https://github.com/mesg-foundation/core/pull/626/files#diff-3ec4078a2b83ce9f8a52b41a8f1f4397R476
-  string ID = 10;                           // Service's unique id service hash.
+  string Hash = 10;                           // Service's unique id service hash.
@ilgooz @krhubert I wonder if it's a breaking change. The type, and the number are the same. Only the name change. What do you think?

It shouldn't be a breaking change. Clients just will keep using ID key. But for the clients that directly imports the pb file from protobbuf pkg, it'll be a breaking change.

ilgooz reviewed

View reviewed changes

database/service_db.go Outdated Show resolved Hide resolved

ilgooz reviewed

View reviewed changes

protobuf/coreapi/api.proto Outdated Show resolved Hide resolved

ilgooz reviewed

View reviewed changes

service/service.go Outdated Show resolved Hide resolved

ilgooz reviewed

View reviewed changes

database/service_db.go Outdated Show resolved Hide resolved

ilgooz reviewed

View reviewed changes

database/service_db_test.go Outdated Show resolved Hide resolved

ilgooz reviewed

View reviewed changes

database/service_db_test.go Outdated Show resolved Hide resolved

ilgooz reviewed

View reviewed changes

database/service_db_test.go Outdated Show resolved Hide resolved

ilgooz reviewed

View reviewed changes

database/service_db_test.go Outdated Show resolved Hide resolved

ilgooz reviewed

View reviewed changes

database/service_db_test.go Outdated Show resolved Hide resolved

ilgooz reviewed

View reviewed changes

database/service_db_test.go Outdated Show resolved Hide resolved

ilgooz approved these changes

View reviewed changes

Contributor

ilgooz left a comment

Some changes are mandatory.

ilgooz suggested changes

View reviewed changes

Contributor

ilgooz left a comment

Some changes are mandatory.

NicolasMahe and others added 6 commits

December 7, 2018 10:29


          Merge branch 'feature/rename-alias-to-sid' into feature/rename-servic…

…e-ID-and-alias

# Conflicts:
#	database/service_db.go
#	database/service_db_test.go
#	protobuf/coreapi/api.pb.go
#	protobuf/coreapi/api.proto
#	service/importer/assets/schema.go


          Apply suggestions from code review

e55c611

Co-Authored-By: NicolasMahe <nicolas@mahe.me>


          Fix merge issue

f2853f5


          Update core api proto

ab0a1b9


          Generate proto

d71b315


          Fix lint

5e05e5d

ilgooz reviewed

View reviewed changes

api/execute.go Show resolved Hide resolved

ilgooz reviewed

View reviewed changes

database/service_db.go Outdated Show resolved Hide resolved

ilgooz reviewed

View reviewed changes

database/service_db.go Outdated Show resolved Hide resolved

ilgooz reviewed

View reviewed changes

protobuf/coreapi/api.proto Outdated Show resolved Hide resolved

ilgooz suggested changes

View reviewed changes

Contributor

ilgooz left a comment

Needs some changes

NicolasMahe and others added 2 commits

December 7, 2018 14:10


          Merge branch 'feature/rename-alias-to-sid' into feature/rename-servic…

480abac

…e-ID-and-alias


          Apply suggestions from code review

8a33ec5

Co-Authored-By: NicolasMahe <nicolas@mahe.me>

Contributor

ilgooz commented Dec 7, 2018

Need to re-gen proto


          Regen proto

59ab827

NicolasMahe changed the base branch from feature/rename-alias-to-sid to dev

December 7, 2018 07:19


          Merge branch 'dev' into feature/rename-service-ID-and-alias

40c5346

Member Author

NicolasMahe commented Dec 7, 2018

Close this PR in favor of #630

NicolasMahe closed this

NicolasMahe deleted the feature/rename-service-ID-and-alias branch

December 7, 2018 08:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet