Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MESG endpoint to the service container #110

Closed
wants to merge 9 commits into from

Conversation

antho1404
Copy link
Member

close #105

@antho1404 antho1404 self-assigned this May 1, 2018
@codecov
Copy link

codecov bot commented May 1, 2018

Codecov Report

Merging #110 into dev will increase coverage by 48.46%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##              dev     #110       +/-   ##
===========================================
+ Coverage   40.42%   88.88%   +48.46%     
===========================================
  Files          27       19        -8     
  Lines         705      198      -507     
===========================================
- Hits          285      176      -109     
+ Misses        412       17      -395     
+ Partials        8        5        -3
Impacted Files Coverage Δ
config/directory.go 73.33% <100%> (+1.9%) ⬆️
api/server.go 92% <100%> (-1.11%) ⬇️
config/api.go 100% <100%> (+54.54%) ⬆️
execution/complete.go
execution/create.go
api/client/api.pb.go
api/service/submit_result.go
api/client/listen_result.go
api/client/execute.go
execution/execute.go
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a1bdd...5b72610. Read the comment docs.

@antho1404
Copy link
Member Author

this one is quite easy but unfortunately the communication between the core and the service doesn't work.

The container cannot have access to the host.

from what I looked it's not supported by swarm
moby/moby#25873
moby/swarmkit#989

I see two solutions for this :

  • We remove swarm and the docker services and we just create normal containers that all have access to the same network 👎
  • We might use a file with an IPC / socket connection like that it's a file to share between the host and the docker service and this is definitely possible we just have to see if we can use grpc with an unix socket or something like that

Any ideas ?

@antho1404
Copy link
Member Author

for information, if I use a system like ngrok to bind your localhost to outside, my service can reach the api and submit events with no problems, it's really just the localhost

@antho1404 antho1404 added the help wanted Extra attention is needed label May 1, 2018
@NicolasMahe
Copy link
Member

That's not cool...
I'm pretty sure gRPC works fine over socket. It uses default net lib that are also compatible with socket.

@antho1404
Copy link
Member Author

Created a socket that is stored in the ~/.mesg/server.sock file, everything is fine if we use it directly but not inside docker, the socket is accessible in the container but we cannot dial anything

Maybe a permission problem, a folder sharing problem or something like that

Any idea ?

@antho1404
Copy link
Member Author

problem with the rebase so new pull request #117

@antho1404 antho1404 closed this May 3, 2018
@antho1404 antho1404 deleted the mesg-endpoint-docker branch May 5, 2018 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add core endpoint as an env variable in the services
2 participants