Add path system to reference nested data in process #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krhubert
force-pushed
the
feature/reference-data
branch
from
4783e50
to
99a1faf
Compare
NicolasMahe
reviewed
Dec 5, 2019
NicolasMahe
reviewed
Dec 5, 2019
NicolasMahe
reviewed
Dec 5, 2019
krhubert
force-pushed
the
feature/reference-data
branch
from
99a1faf
to
05fde2d
Compare
krhubert
force-pushed
the
feature/reference-data
branch
from
05fde2d
to
fa11edc
Compare
|
optional path test added |
NicolasMahe
approved these changes
Dec 6, 2019
krhubert
changed the title
# Conflicts: # process/process.pb.go
NicolasMahe
changed the title
NicolasMahe
changed the title
|
TODO:
|
antho1404
approved these changes
Dec 13, 2019
| @@ -259,3 +260,51 @@ func (s *Orchestrator) processTask(nodeKey string, task *process.Process_Node_Ta | |||
| }, s.accountName, s.accountPassword) | |||
| return err | |||
| } | |||
|
|
|||
| func resolveRef(data *types.Struct, path *process.Process_Node_Map_Output_Reference_Path) (*types.Value, error) { | |||
There was a problem hiding this comment.
I find this code really complicated with the v that is assigned in multiple places and the iteration over the path from an existing path. I think this would be much simpler with a recursive function.
| @@ -224,9 +225,9 @@ func (s *Orchestrator) resolveInput(wfHash hash.Hash, exec *execution.Execution, | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| return s.resolveInput(wfHash, parent, nodeKey, outputKey) | |||
| return s.resolveInput(wfHash, parent, nodeKey, path) | |||
There was a problem hiding this comment.
resolveInput wasn't resolving any path, I just added a commit with the fix
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dep #1540
close #1306