Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos implementation simplification #1554

Merged
merged 8 commits into from Jan 31, 2020
Merged

Cosmos implementation simplification #1554

merged 8 commits into from Jan 31, 2020

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented Dec 10, 2019 •
edited

Summary of this PR:

  • remove cosmos app and cosmos app factory structure 🍾
  • simplify cosmos module helper
  • separate initialization of App and BasicManager
  • BasicManager using the modules' AppModuleBasic struct is stateless and enough to generate the genesis or any client (CLI). No need to init the whole app the generate the genesis or start the cosmos CLI
  • init cosmos app (using modules of engine and cosmos) in sdk/modules.go
  • separate sdk's backend to keeper (logic on the data) and module (module's handler and querier).

@NicolasMahe NicolasMahe self-assigned this Dec 10, 2019
@NicolasMahe NicolasMahe added this to In progress in Sprint weeks 2 & 3 Dec 12, 2019
@NicolasMahe NicolasMahe moved this from In progress to Done in Sprint weeks 2 & 3 Dec 12, 2019
@NicolasMahe NicolasMahe removed this from Done in Sprint weeks 2 & 3 Dec 12, 2019
NicolasMahe
NicolasMahe commented Dec 18, 2019
View reviewed changes
sdk/modules.go Outdated Show resolved Hide resolved
NicolasMahe
NicolasMahe commented Dec 18, 2019
View reviewed changes
Copy link
Member Author

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to generate the app / cli / etc using the https://github.com/cosmos/scaffold

@NicolasMahe NicolasMahe added this to In progress in Sprint weeks 4 & 5 via automation Jan 29, 2020
@NicolasMahe NicolasMahe marked this pull request as ready for review January 29, 2020 09:44
@NicolasMahe NicolasMahe added this to the next milestone Jan 29, 2020
@NicolasMahe NicolasMahe moved this from In progress to To review in Sprint weeks 4 & 5 Jan 29, 2020
krhubert
krhubert reviewed Jan 30, 2020
View reviewed changes
sdk/execution/module.go Outdated Show resolved Hide resolved
sdk/instance/module.go Outdated Show resolved Hide resolved
sdk/ownership/module.go Outdated Show resolved Hide resolved
sdk/process/module.go Outdated Show resolved Hide resolved
sdk/runner/module.go Outdated Show resolved Hide resolved
sdk/service/module.go Outdated Show resolved Hide resolved
@NicolasMahe NicolasMahe merged commit 13ac313 into dev Jan 31, 2020
Sprint weeks 4 & 5 automation moved this from To review to Done Jan 31, 2020
@NicolasMahe NicolasMahe deleted the feature/module-simplification branch January 31, 2020 07:51
@NicolasMahe NicolasMahe added the release:change Pull requests that change something existant label Feb 5, 2020
@NicolasMahe NicolasMahe changed the title Cosmos Module simplification Cosmos implementation simplification Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 antho1404 approved these changes

@krhubert krhubert Awaiting requested review from krhubert

Assignees

@NicolasMahe NicolasMahe

Labels
release:change Pull requests that change something existant
Projects
No open projects
Sprint weeks 4 & 5
  
Done
Milestone
v0.18.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NicolasMahe @antho1404 @krhubert