Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor package config #427

Merged
merged 25 commits into from Sep 11, 2018
Merged

Refactor package config #427

merged 25 commits into from Sep 11, 2018

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented Sep 5, 2018 •
edited

  • Remove Viper
  • Use envconfig for loading conf fron env
  • Use a dedicated config struct
  • Should use this config struct by using config.Global() anywhere in the codebase

I add a hack that change the config.Path value in order to make tests that used the database works. Otherwise, the tests tried to create the directory /mesg and failed because of permission. This should be removed when the database package in mockable.

-ldflags="-X 'github.com/mesg-foundation/core/config.Path=./'"

@NicolasMahe
Replace APIServerAddress and APIClientTarget by APIGRPCPort and APIGR…
5c3cc3c 
…PCAddresss
@NicolasMahe
Make viper look for a config file named ".mesg.XXX" in the current an…
70bb704 
…d home directories
@NicolasMahe
Rename MESGPath to Path and set a hard coded default
73fdb68
@NicolasMahe
Remove useless creation of directory
f7f3224
@NicolasMahe
Reorganise APIGRPCPort and APIGRPCAddresss to APIPort and APIAddress
6d964e9
@NicolasMahe
Remove Path from viperConfig in favor of a constant
0f2d5f1
@NicolasMahe
Remove daemon.path constant in favor of config.Path
3f05abf
@NicolasMahe
Introduce new package config
2eb4c6a
@NicolasMahe
Improve new config type
75a306d
@NicolasMahe
Remove interface setting in favor of interface engine
d33bb03
@NicolasMahe
Transform viperSetting to viperEngine and update the rest of the package
618e036
@NicolasMahe
add comments
f69d7ad
@NicolasMahe
Update the codebase to use the new config package
471bafd
@NicolasMahe
Introduce hack to change the path when running test
840700c
@NicolasMahe NicolasMahe added this to the v1.2.0 milestone Sep 5, 2018
@NicolasMahe NicolasMahe mentioned this pull request Sep 6, 2018
Closed
@NicolasMahe
Copy link
Member Author

@mesg-foundation/core this PR is ready for reviews

@NicolasMahe
Copy link
Member Author

@mesg-foundation/core ready to review.

@antho1404 antho1404 merged commit 052c4ae into dev Sep 11, 2018
@antho1404 antho1404 deleted the feature/better-config branch September 11, 2018 09:45
@antho1404 antho1404 mentioned this pull request Sep 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 antho1404 approved these changes

@krhubert krhubert krhubert approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NicolasMahe @antho1404 @krhubert