fix sync issue on status send chans and sync issue on gRPC deploy stream sends #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eam sends, closes #515
ilgooz
force-pushed
the
feature/fix-deploy-status-chan-sync
branch
from
72b2dab
to
d31f4ce
Compare
krhubert
reviewed
Oct 4, 2018
|
What was the issue that this PR fixes? |
it solves several synchronization bugs in the code. for the case with gRPC, if we don't have this waiter, there is a possibility of ending the stream by sending the last message (serviceID or validationErr). In that case if we cannot send all the status messages before, they will be lost. same thing happens in some other places where status messages are send. for example for in commands package there is a possibility that execution of dev/deploy commands will be done before printing all of the status messages to os.Stdout. |
NicolasMahe
requested changes
Oct 15, 2018
|
good to review |
NicolasMahe
approved these changes
Oct 17, 2018
krhubert
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.