109 azurebootstrap spn readonly #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
chore: adding comments to tenant fw rules
florianow
force-pushed
the
109-azurebootstrap-spn-readonly
branch
from
0715353
to
64a1062
Compare
florianow
force-pushed
the
109-azurebootstrap-spn-readonly
branch
from
8aaafcd
to
05767d9
Compare
florianow
force-pushed
the
109-azurebootstrap-spn-readonly
branch
from
858184b
to
8269d8d
Compare
florianow
force-pushed
the
109-azurebootstrap-spn-readonly
branch
from
37bf2a8
to
4e35e61
Compare
felixzieger
approved these changes
Mar 7, 2024
florianow
commented
Mar 7, 2024
| } | ||
|
|
||
| resource "azurerm_role_definition" "cloudfoundation_deploy" { | ||
| name = var.platform_engineers_group |
There was a problem hiding this comment.
@felixzieger i choose the same name for the role as for the group. do you have any concerns?
| @@ -0,0 +1,32 @@ | |||
| # allow reading terraform state | |||
|
|
|||
| # important caveat: the current, simplified design of the bootstrap module means that this the docs UAMI can read | |||
There was a problem hiding this comment.
@florianow this is no longer applicable, i.e. there is no more bootstrap SPN credential, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.