New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/restructure terragrunt bootstrap #33
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
dd91b17
to
720b839
Compare
7cabf36
to
7b61d7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but strongly suggest a few further tweaks
kit/azure/bootstrap/README.md
Outdated
|
||
|
||
## additional UPN handling | ||
Usefull if you need to translate emails into UPNs as necessary, shown here with guest users. You could add this code block |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useful
kit/azure/bootstrap/README.md
Outdated
@@ -15,7 +15,29 @@ cfmm: | |||
# azure/bootstrap | |||
|
|||
This documentation is intended as a reference documentation for cloud foundation or platform engineers using this module. | |||
|
|||
|
|||
## additional UPN handling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPN handling for AAD Guest users
kit/azure/bootstrap/README.md
Outdated
|
||
## additional UPN handling | ||
Usefull if you need to translate emails into UPNs as necessary, shown here with guest users. You could add this code block | ||
to your `terragrunt.hcl` instead of using out of the the `ìnputs`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double the. that sentence doesn't read right. Ask chatgpt or gramarly to spellcheck?
@@ -36,33 +36,18 @@ provider "azuread" { | |||
EOF | |||
} | |||
|
|||
|
|||
locals { | |||
inputs = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d: should we autogenerate this with terraform-docs tfvars hcl ./ --description
for consistency with (planned) collie kit apply
beahvior?
No description provided.