Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/restructure terragrunt bootstrap #33

Merged
merged 4 commits into from Jul 26, 2023

Conversation

florianow
Copy link
Collaborator

No description provided.

@aws-amplify-eu-central-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-33.dqjue86f8tzdw.amplifyapp.com

@florianow florianow force-pushed the feature/restructure-terragrunt-bootstrap branch from dd91b17 to 720b839 Compare July 26, 2023 12:48
@florianow florianow force-pushed the feature/restructure-terragrunt-bootstrap branch from 7cabf36 to 7b61d7c Compare July 26, 2023 15:50
Copy link
Member

@JohannesRudolph JohannesRudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but strongly suggest a few further tweaks



## additional UPN handling
Usefull if you need to translate emails into UPNs as necessary, shown here with guest users. You could add this code block
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useful

@@ -15,7 +15,29 @@ cfmm:
# azure/bootstrap

This documentation is intended as a reference documentation for cloud foundation or platform engineers using this module.


## additional UPN handling
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPN handling for AAD Guest users


## additional UPN handling
Usefull if you need to translate emails into UPNs as necessary, shown here with guest users. You could add this code block
to your `terragrunt.hcl` instead of using out of the the `ìnputs`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double the. that sentence doesn't read right. Ask chatgpt or gramarly to spellcheck?

@@ -36,33 +36,18 @@ provider "azuread" {
EOF
}


locals {
inputs = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d: should we autogenerate this with terraform-docs tfvars hcl ./ --description for consistency with (planned) collie kit apply beahvior?

@florianow florianow merged commit afddbe0 into main Jul 26, 2023
1 check passed
@JohannesRudolph JohannesRudolph deleted the feature/restructure-terragrunt-bootstrap branch July 26, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants