Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add standard vnet config file for buildingblock definition #79

Merged
merged 5 commits into from Nov 6, 2023

Conversation

ishabakeh
Copy link
Contributor

No description provided.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-79.dqjue86f8tzdw.amplifyapp.com

@ishabakeh ishabakeh merged commit f6cde5c into main Nov 6, 2023
2 checks passed
@ishabakeh ishabakeh deleted the feature/Buildingblocks-config-kit branch November 6, 2023 13:56
@JohannesRudolph
Copy link
Member

@ishabakeh a few things don't add up here

  • why is this called standard-vnet when it is not deploying any vnet?
  • there are some issues with the tf code, ie. I it's not clear why I would want to either adopt existing spn/storage account with submodules (e.g. import blocks are an alternative)
  • we need to provide clear guidance on the purpose of this module

@ishabakeh
Copy link
Contributor Author

  • The module is the configuration for the standard-vnet BB that we already have
  • We are still looking for the best place for this config modules, but in the meantime we wanted to try its functionality with "collie kit import" but the Storage creation module will be moved from here and be another standalone module itself. I'm Thinking that we have separate Storage module for creation of backend module for all building blocks, and for Service principals, it make sense that engineers be able to either try the one they already have from bootstrap (for dev or test purposes) or create a new one right away with minimum effort
  • the purpose is to generate backend config and provider credentials and later other pre-requisites for deploying a buildingblock
  • Guidance will be also changed and completed

@ishabakeh ishabakeh restored the feature/Buildingblocks-config-kit branch November 8, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants