Created and Updated config.yml #39
Conversation
shashanksjSSJ
force-pushed
the
Shashank-S-J-
branch
from
7b49583
to
1433980
Compare
|
@ShivangShandilya ready for review. |
|
have you added meshery-celebration-dark and meshery-celebration-light svgs in .github/welcome/ |
|
@Ghat0tkach, when the background is light, shouldn't the logo be dark so that it could be visible to the users and same goes for the dark theme, it is light because the background-color is dark, if anything is wrong please inform me, the other change I make correct the changes now, sorry for the trouble, I am a newbie 😄 |
shashanksjSSJ
force-pushed
the
Shashank-S-J-
branch
from
539dcbb
to
7eb1be5
Compare
|
@Ghat0tkach, I have updated it like you told me to do, like I have described in my previous commit, I have copied and pasted the code from meshery/meshery therefore, I did not make any significant changes in the code as the images were working as expected, 😄 👍 |
.github/config.yml
Outdated
|
|
||
| <picture> | ||
| <source media="(prefers-color-scheme: dark)" srcset=".github/welcome/Meshery_Welcome_light.png"> | ||
| <source media="(prefers-color-scheme: light)" srcset=".github/welcome/Meshery_Welcome_light.png"> | ||
| <img alt="Meshery Logo" src=""> | ||
| </picture> | ||
|
|
There was a problem hiding this comment.
Here I think @shashanksjSSJ , srcset needs to be a reference to absolute path to raw image.
Also the in the srcset both the images you have named as Meshery_Welcome_light so correct that too one should be named dark.
I'm also mentioning a PR where you can get better idea of what i'm talking about - Meshkit - #308
There was a problem hiding this comment.
@shashanksjSSJ for your contribution.
Can you please use SVG format for the images and keep the files name in lowercase besides having an absolute path?
There was a problem hiding this comment.
I need to change the raw link to /meshery/meshery right
shashanksjSSJ
force-pushed
the
Shashank-S-J-
branch
from
4b75a58
to
7cac41a
Compare
|
Hey @ShivangShandilya, I have uploaded the images into .github/welcome and then used raw image path for srcset, may be I need to change the image link /shashanksjSSJ/homebrew-tap/master/ to /mershery/homebrew-tap/master/, what do you think? 😅 |
|
@shashanksjSSJ please use absolute path like this and rename files to lowercase. |
|
@goldfishdolphin, I have used https://raw.githubusercontent.com/meshery/homebrewtap/master/.github/assets/images/meshery-celebration-dark.svg instead of |
Signed off by: shashanksjSSJ <shashanksj26@gmail.com> Hello @leecalcote, I have added config.yml from meshery/meshery, as the images were already updated I haven't made a lot of changes in them. I have submitted this for your review, and I want to thank @leecalcote for letting me contribute to the organization, this helped me to learn a lot. Signed-off-by: Shashank S J <98632070+shashanksjSSJ@users.noreply.github.com>
I have added the images into .github/welcome, and have made required changes in .github/config.yml as well. The reason why I had not done this previously was because, I had copied this code from meshery/meshery like @leecalcote told me and pasted it directly into .github/config.yml, as the images were already linked, i.e, I did not make any significant changes like I have give in my previous commit description. Signed-off-by: Shashank S J <98632070+shashanksjSSJ@users.noreply.github.com>
I have changed the srcset to raw image link, may be after you merge we need to change the link to /meshery. Signed-off-by: Shashank S J <98632070+shashanksjSSJ@users.noreply.github.com>
Signed-off-by: Shashank S J <98632070+shashanksjSSJ@users.noreply.github.com>
Signed-off-by: Shashank S J <98632070+shashanksjSSJ@users.noreply.github.com>
Signed-off-by: Shashank S J <98632070+shashanksjSSJ@users.noreply.github.com>
@goldfishdolphin, I have updated the images to svg, and I have changed the srcset which actually had to be raw path of the svg's in my directory to meshery/homebrew-tap/master this way it can be made sure that even after the merge happens the image raw link remains the same. Signed-off-by: Shashank S J <98632070+shashanksjSSJ@users.noreply.github.com>
shashanksjSSJ
force-pushed
the
Shashank-S-J-
branch
from
dd79e1a
to
2fd4373
Compare
| <img alt="Meshery Logo" src=""> | ||
| </picture> | ||
|
|
||
| 	 	 	 	 [Join the community](http://slack.layer5.io), if you haven't yet and please leave a :star: [star on the project](../stargazers). :smile: |
There was a problem hiding this comment.
@ShivangShandilya and @thisiskaransgit, I don't think line 26 is needed here. It does not sync with other Meshery repos celebration theme.
There was a problem hiding this comment.
I wonder why we removed this from the other repos. It's helpful to both invite people to the Slack and to star the repo. I encourage us to leave this message included.
|
Thank you, @goldfishdolphin |
|
Thanks for your contribution to Meshery! 🎉
|
|
Good work, @shashanksjSSJ |
Hello @leecalcote, I have added config.yml from meshery/meshery, as the images were already updated I haven't made a lot of changes in them. I have submitted this for your review, and I want to thank @leecalcote for letting me contribute to the organization, this helped me to learn a lot.
Please inform me if there are any changes that I need to make.
Signed-off-by: shashanksjSSJ shashanksj26@gmail.com