Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed adapter from istio to consul for Docker image tag #306

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

acald-creator
Copy link
Contributor

Signed-off-by: Antonette Caldwell pullmana8@gmail.com

Description

This PR fixes #

Makefile includes the adapter choice as istio, not consul

Notes for Reviewers

Signed commits

  • [ x ] Yes, I signed my commits.

Signed-off-by: Antonette Caldwell <pullmana8@gmail.com>
@welcome
Copy link

welcome bot commented Sep 16, 2022

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. 👍

@leecalcote leecalcote merged commit 0a17b86 into meshery:master Sep 16, 2022
@welcome
Copy link

welcome bot commented Sep 16, 2022

Thanks for your contribution to the Layer5 community! 🎉

Congrats!
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

@acald-creator acald-creator deleted the fix-makefile branch September 17, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants