-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the Logo of Layer5 with Meshery in config.yml workflow #104
Comments
@thisiskaransgit kindly assign me this issue |
Hi @thisiskaransgit , Can I work on this issue? |
@Amukayoung since you are already assigned a similar issue, assigning @Shyam-12 for this one 🚀 |
Hi @thisiskaransgit , I have made the changes, I should be pulling request on the meshery folder right where I have made the changes, but this issue is not there on the main meshery folder. Please guide me a little bit, a little confused, I have done all the changes and committed but not sure where to pull request? Thank You! |
Here's how you can go ahead:
|
The Pull Request will go inside this repository only. Changes also need to be done inside this repository. |
Alright got it, I thought I needed to update the meshery repo. Will be making the changes in few minutes. Thank you! |
Signed-off-by: Shyam-12 <shyamprasad1248@gmail.com>
@anshgoyalevil, I have pulled a request, kindly review it, and please give any feedback or any changes if any. Thank you :) |
Signed-off-by: Shyam-12 <shyamprasad1248@gmail.com>
Signed-off-by: Shyam-12 <shyamprasad1248@gmail.com>
Signed-off-by: Shyam-12 <shyamprasad1248@gmail.com>
@Shyam-12 mention the fixed issue in the PR description, to link it. |
I have added the PR description, please check and let me know if it's fine
or not.
…On Thu 18 May, 2023, 12:33 AM Karan Thakur, ***@***.***> wrote:
@Shyam-12 <https://github.com/Shyam-12> mention the fixed issue in the PR
description, to link it.
—
Reply to this email directly, view it on GitHub
<#104 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARKRO4E47OC32V2LRFIB4ITXGUOJRANCNFSM6AAAAAAW3XYRYA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Fixing issue #104: Updated welcome image and config.yml
Description
Currently, we are using the Logo of Layer5 instead of Meshery. This repository is under the organization Meshery, so, there should be the image of Meshery.
How to resolve this?
Go to .github and replace this welcome image with the new one:
Make sure to display the images conditionally, based on the theme selected by user.
Here's the sample code:
New images are:
Download these images, and upload with an appropriate name. Make sure to use conditional rendering as described above.
After uploading the image, and removing the previous image, go to .github/config.yml folder and update the reference to previous image to the new image in the following part:
Here, replace
![Congrats!](https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Layer5-celebration.png)
with the codemake sure to change the image sources with the path to image in the folder where you upload it.
Contributor Guides and Handbook
The text was updated successfully, but these errors were encountered: