Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the Logo of Layer5 with Meshery in config.yml workflow #104

Closed
anshgoyalevil opened this issue Apr 12, 2023 · 10 comments · Fixed by #106
Closed

Replace the Logo of Layer5 with Meshery in config.yml workflow #104

anshgoyalevil opened this issue Apr 12, 2023 · 10 comments · Fixed by #106
Assignees
Labels
good first issue Good for newcomers kind/enhancement New feature or request

Comments

@anshgoyalevil
Copy link
Member

anshgoyalevil commented Apr 12, 2023

Description

Currently, we are using the Logo of Layer5 instead of Meshery. This repository is under the organization Meshery, so, there should be the image of Meshery.

How to resolve this?

  • Go to .github and replace this welcome image with the new one:

  • Make sure to display the images conditionally, based on the theme selected by user.
    Here's the sample code:

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/w.png">
  <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/b.png">
  <img alt="Meshery Logo" src="">
</picture>

New images are:

Meshery-celebration-Light
Meshery-celebration-Dark

  • Download these images, and upload with an appropriate name. Make sure to use conditional rendering as described above.

  • After uploading the image, and removing the previous image, go to .github/config.yml folder and update the reference to previous image to the new image in the following part:

firstPRMergeComment: >
  Thanks for your contribution to the Layer5 and Meshery community! :tada:
   
  ![Congrats!](https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Layer5-celebration.png)
  &nbsp; &#9; &nbsp; &#9;  &nbsp; &#9;  &nbsp; &#9; :star: Please leave a [star on the project](../stargazers). :smile:

Here, replace ![Congrats!](https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Layer5-celebration.png) with the code

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/w.png">
  <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/b.png">
  <img alt="Shows a black logo in light color mode and a white one in dark color mode." src="https://user-images.githubusercontent.com/25423296/163456779-a8556205-d0a5-45e2-ac17-42d089e3c3f8.png">
</picture>

make sure to change the image sources with the path to image in the folder where you upload it.

  • That's it.

Contributor Guides and Handbook

@thisiskaransgit thisiskaransgit added kind/enhancement New feature or request good first issue Good for newcomers labels May 15, 2023
@Amukayoung
Copy link

@thisiskaransgit kindly assign me this issue

@Shyam-12
Copy link
Contributor

Shyam-12 commented May 16, 2023

Hi @thisiskaransgit , Can I work on this issue?

@thisiskaransgit
Copy link
Contributor

@Amukayoung since you are already assigned a similar issue, assigning @Shyam-12 for this one 🚀

@Shyam-12
Copy link
Contributor

Hi @thisiskaransgit , I have made the changes, I should be pulling request on the meshery folder right where I have made the changes, but this issue is not there on the main meshery folder. Please guide me a little bit, a little confused, I have done all the changes and committed but not sure where to pull request? Thank You!

@anshgoyalevil
Copy link
Member Author

anshgoyalevil commented May 16, 2023

@Shyam-12

Here's how you can go ahead:

  • Fork this repository "meshery-cpx"
  • Create a new config.yml inside the .github folder. You may copy the contents for this file from other repos inside Meshery Organization.
  • Add the welcome images to either .github/welcome folder, or ./github/assets/images/welcome folder. You would need to research on how to create directories in a GitHub repo. (Hint: Drag and drop a similar folder from the local machine).
  • Update the config.yml with correct srcset to raw images which you just uploaded.

@anshgoyalevil
Copy link
Member Author

Hi @thisiskaransgit , I have made the changes, I should be pulling request on the meshery folder right where I have made the changes, but this issue is not there on the main meshery folder. Please guide me a little bit, a little confused, I have done all the changes and committed but not sure where to pull request? Thank You!

The Pull Request will go inside this repository only. Changes also need to be done inside this repository.

@Shyam-12
Copy link
Contributor

Alright got it, I thought I needed to update the meshery repo. Will be making the changes in few minutes. Thank you!

Shyam-12 added a commit to Shyam-12/meshery-cpx that referenced this issue May 16, 2023
Signed-off-by: Shyam-12 <shyamprasad1248@gmail.com>
@Shyam-12
Copy link
Contributor

Shyam-12 commented May 16, 2023

@anshgoyalevil, I have pulled a request, kindly review it, and please give any feedback or any changes if any. Thank you :)

Shyam-12 added a commit to Shyam-12/meshery-cpx that referenced this issue May 16, 2023
Signed-off-by: Shyam-12 <shyamprasad1248@gmail.com>
Shyam-12 added a commit to Shyam-12/meshery-cpx that referenced this issue May 16, 2023
Signed-off-by: Shyam-12 <shyamprasad1248@gmail.com>
Shyam-12 added a commit to Shyam-12/meshery-cpx that referenced this issue May 17, 2023
Signed-off-by: Shyam-12 <shyamprasad1248@gmail.com>
@thisiskaransgit
Copy link
Contributor

@Shyam-12 mention the fixed issue in the PR description, to link it.

@Shyam-12
Copy link
Contributor

Shyam-12 commented May 18, 2023 via email

leecalcote added a commit that referenced this issue Jul 4, 2023
Fixing issue #104: Updated welcome image and config.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants