Add missing custom component files #575

ayushthe1 · 2023-04-28T20:50:40Z

Description

This PR fixes #574 and fixes #583

Notes for Reviewers

Signed commits

Yes, I signed my commits.

Signed-off-by: ayushthe1 <ayushsharmaa101@gmail.com>

leecalcote · 2023-04-29T05:29:01Z

@ayushthe1 add a reviewer, please. add appropriate labels, too, please.

ayushthe1 · 2023-04-29T06:24:17Z

@leecalcote I don't have the permissions to do that. Could you please add it.

Aisuko · 2023-05-11T02:31:37Z

Hi, guys. There are tons of files and are hard to review.

leecalcote · 2023-05-11T03:31:09Z

@ayushthe1 you do have permission to manage issue labels...

@Aisuko you're right. It's completely overwhelming.

gyohuangxin · 2023-06-06T02:01:53Z

@ayushthe1 Is there any new update, can we keep going? Thanks.

Revolyssup · 2023-06-06T08:46:07Z

@ayushthe1 You need to pass the CI here https://github.com/meshery/meshery-istio/actions/runs/4834663217/jobs/8616162477?pr=575

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>

theBeginner86 · 2023-06-06T09:27:52Z

Updated the model name

Signed-off-by: Ayush Sharma <ayushsharmaa101@gmail.com>

gyohuangxin · 2023-06-07T07:00:04Z

There are still some failed CI tests, @theBeginner86 do you know how to resolve this?

theBeginner86 · 2023-06-08T16:42:35Z

I added the missing model name in service-mesh-patterns/service-mesh-patterns#106.

Which should fix the last set of tests.

theBeginner86 · 2023-06-09T09:27:17Z

This PR service-mesh-patterns/service-mesh-patterns#107 would solve the last set of tests that checks the sample apps.

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>

…into addFiles Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>

theBeginner86 · 2023-06-09T09:36:37Z

updated filename reference for sample app design to bookInfo.yaml

theBeginner86 · 2023-06-09T10:35:32Z

service-mesh-patterns/service-mesh-patterns#108

theBeginner86 · 2023-06-09T10:51:18Z

All ✅

Lets merge this

gyohuangxin · 2023-06-11T09:31:21Z

Thank you for your efforts to resolve this issue !👍 Which release will contain this patch and when will it happen?

theBeginner86 · 2023-06-11T09:33:21Z

Thank you for your efforts to resolve this issue !👍 Which release will contain this patch and when will it happen?

Its already released in latest meshery-istio adapter. https://github.com/meshery/meshery-istio/releases/tag/v0.6.11

gyohuangxin · 2023-06-12T02:38:12Z

@theBeginner86 I've updated meshery-istio to v0.6.11,

and this is my pattern yaml file:

name: Istio Installation with CryptoMB
services:
  istioservicemesh:
    name: istioservicemesh
    type: IstioMesh
    model: ISTIO
    namespace: "istio-system"
    settings:
      profile: default
      version: 1.17.2
    traits:
      components:
        ingressGateways:
        - enabled: true
          name: istio-ingressgateway
          k8s:
            overlays:
              - kind: Deployment
                name: istio-ingressgateway
                patches:
                - path: spec.template.spec.containers.[name:istio-proxy].args.[-1]
                  value: "--concurrency=4"
            # Limit CPU/MEM usage to 4 vCPUs/4 GB for QoS reasons.
            # Enable CPU manager static policy in kubelet to even more deterministic results.
            resources:
              requests:
                cpu: 4000m
                memory: 4096Mi
              limits:
                cpu: 4000m
                memory: 4096Mi
            hpaSpec:
              maxReplicas: 1
              minReplicas: 1
            podAnnotations: # this controls the SDS service which configures ingress gateway
              proxy.istio.io/config: |
                privateKeyProvider:
                  cryptomb:
                    pollDelay: 10ms
      automaticSidecarInjection:
        namespaces:
        - default
      meshmap:
        edges: []
        id: istioservicemesh
        label: istioservicemesh
        position:
          posX: 59.458251455094434
          posY: 5.53595199333449

but it still failed with error:

Is there something wrong with my configuration? Could you please give me an example for that?

Revolyssup · 2023-06-12T05:13:08Z

@theBeginner86 I've updated meshery-istio to v0.6.11,

and this is my pattern yaml file:

name: Istio Installation with CryptoMB
services:
  istioservicemesh:
    name: istioservicemesh
    type: IstioMesh
    model: ISTIO
    namespace: "istio-system"
    settings:
      profile: default
      version: 1.17.2
    traits:
      components:
        ingressGateways:
        - enabled: true
          name: istio-ingressgateway
          k8s:
            overlays:
              - kind: Deployment
                name: istio-ingressgateway
                patches:
                - path: spec.template.spec.containers.[name:istio-proxy].args.[-1]
                  value: "--concurrency=4"
            # Limit CPU/MEM usage to 4 vCPUs/4 GB for QoS reasons.
            # Enable CPU manager static policy in kubelet to even more deterministic results.
            resources:
              requests:
                cpu: 4000m
                memory: 4096Mi
              limits:
                cpu: 4000m
                memory: 4096Mi
            hpaSpec:
              maxReplicas: 1
              minReplicas: 1
            podAnnotations: # this controls the SDS service which configures ingress gateway
              proxy.istio.io/config: |
                privateKeyProvider:
                  cryptomb:
                    pollDelay: 10ms
      automaticSidecarInjection:
        namespaces:
        - default
      meshmap:
        edges: []
        id: istioservicemesh
        label: istioservicemesh
        position:
          posX: 59.458251455094434
          posY: 5.53595199333449

but it still failed with error:

Is there something wrong with my configuration? Could you please give me an example for that?

Can you share the logs of istio adapter?

Revolyssup · 2023-06-12T05:15:15Z

@gyohuangxin Did you create the above configuration from Meshmap or is it handtyped

gyohuangxin · 2023-06-12T05:42:11Z

@Revolyssup I handtyped it, and I didn't see any logs in Istio adapter, the error happened in meshery main process:

meshery-meshery-1        | time="2023-06-12T05:51:21Z" level=info msg="kubernetes contexts successfully retrieved from remote provider"
meshery-meshery-1        | time="2023-06-12T05:51:21Z" level=info msg="attempting to fetch patterns resource from cloud"
meshery-meshery-1        | time="2023-06-12T05:51:21Z" level=info msg="pattern resources successfully retrieved from remote provider"
meshery-meshery-1        | map[string]interface {}{"name":"Istio Installation with CryptoMB", "services.istioservicemesh.id":"47565a89-f7c3-4d76-9304-10c8d67fd999", "services.istioservicemesh.model":"ISTIO", "services.istioservicemesh.name":"istioservicemesh", "services.istioservicemesh.namespace":"istio-system", "services.istioservicemesh.settings.profile":"default", "services.istioservicemesh.settings.version":"1.17.2", "services.istioservicemesh.traits.automaticSidecarInjection.namespaces.0":"default", "services.istioservicemesh.traits.components.ingressGateways.0.enabled":true, "services.istioservicemesh.traits.components.ingressGateways.0.k8s.hpaSpec.maxReplicas":1, "services.istioservicemesh.traits.components.ingressGateways.0.k8s.hpaSpec.minReplicas":1, "services.istioservicemesh.traits.components.ingressGateways.0.k8s.overlays.0.kind":"Deployment", "services.istioservicemesh.traits.components.ingressGateways.0.k8s.overlays.0.name":"istio-ingressgateway", "services.istioservicemesh.traits.components.ingressGateways.0.k8s.overlays.0.patches.0.path":"spec.template.spec.containers.[name:istio-proxy].args.[-1]", "services.istioservicemesh.traits.components.ingressGateways.0.k8s.overlays.0.patches.0.value":"--concurrency=4", "services.istioservicemesh.traits.components.ingressGateways.0.k8s.podAnnotations.proxy.istio.io/config":"privateKeyProvider:\n  cryptomb:\n    pollDelay: 10ms\n", "services.istioservicemesh.traits.components.ingressGateways.0.k8s.resources.limits.cpu":"4000m", "services.istioservicemesh.traits.components.ingressGateways.0.k8s.resources.limits.memory":"4096Mi", "services.istioservicemesh.traits.components.ingressGateways.0.k8s.resources.requests.cpu":"4000m", "services.istioservicemesh.traits.components.ingressGateways.0.k8s.resources.requests.memory":"4096Mi", "services.istioservicemesh.traits.components.ingressGateways.0.name":"istio-ingressgateway", "services.istioservicemesh.traits.meshmap.id":"istioservicemesh", "services.istioservicemesh.traits.meshmap.label":"istioservicemesh", "services.istioservicemesh.traits.meshmap.position.posX":59.458251455094434, "services.istioservicemesh.traits.meshmap.position.posY":5.53595199333449, "services.istioservicemesh.type":"IstioMesh"}
meshery-meshery-1        | IstioMesh ISTIO
meshery-meshery-1        | time="2023-06-12T05:51:21Z" level=error msg="could not find component with name: IstioMesh, model: ISTIO, apiVersion: "
meshery-meshery-1        | time="2023-06-12T05:51:21Z" level=error msg="could not find component with name: IstioMesh, model: ISTIO, apiVersion: " app=meshery code=2012 probable-cause= severity=2 short-description="unable to Create Comp Config..could not find component with name: IstioMesh, model: ISTIO, apiVersion: " suggested-remediation=

ayushthe1 added 3 commits April 29, 2023 01:12

fix 1

414da59

Signed-off-by: ayushthe1 <ayushsharmaa101@gmail.com>

fix 2

b4cecca

Signed-off-by: ayushthe1 <ayushsharmaa101@gmail.com>

fix 3

116c99b

Signed-off-by: ayushthe1 <ayushsharmaa101@gmail.com>

leecalcote requested a review from Revolyssup April 29, 2023 07:52

ayushthe1 requested a review from Aisuko May 10, 2023 10:55

Aisuko added the service-mesh/istio Issues related to Istio label May 11, 2023

This comment was marked as outdated.

Sign in to view

update install/ workflows

35db953

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>

ayushthe1 added 2 commits June 6, 2023 15:20

Merge branch 'master' into addFiles

d453d3f

Update deploywithsampleapp.yaml

477b091

Signed-off-by: Ayush Sharma <ayushsharmaa101@gmail.com>

Merge branch 'master' into addFiles

529f653

theBeginner86 added 2 commits June 9, 2023 15:01

update filename reference for bookinfo

163e03c

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>

Merge branch 'addFiles' of https://github.com/ayushthe1/meshery-istio …

10c0e83

…into addFiles Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>

theBeginner86 merged commit e6ab677 into meshery:master Jun 9, 2023
26 checks passed

theBeginner86 mentioned this pull request Jun 9, 2023

Change model to ISTIO #584

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing custom component files #575

Add missing custom component files #575

ayushthe1 commented Apr 28, 2023 •

edited

leecalcote commented Apr 29, 2023

ayushthe1 commented Apr 29, 2023

Aisuko commented May 11, 2023

leecalcote commented May 11, 2023

This comment was marked as outdated.

This comment was marked as outdated.

gyohuangxin commented Jun 6, 2023

Revolyssup commented Jun 6, 2023 •

edited

theBeginner86 commented Jun 6, 2023

gyohuangxin commented Jun 7, 2023

theBeginner86 commented Jun 8, 2023 •

edited

theBeginner86 commented Jun 9, 2023

theBeginner86 commented Jun 9, 2023

theBeginner86 commented Jun 9, 2023

theBeginner86 commented Jun 9, 2023

gyohuangxin commented Jun 11, 2023

theBeginner86 commented Jun 11, 2023

gyohuangxin commented Jun 12, 2023

Revolyssup commented Jun 12, 2023

Revolyssup commented Jun 12, 2023

gyohuangxin commented Jun 12, 2023

Add missing custom component files #575

Add missing custom component files #575

Conversation

ayushthe1 commented Apr 28, 2023 • edited

leecalcote commented Apr 29, 2023

ayushthe1 commented Apr 29, 2023

Aisuko commented May 11, 2023

leecalcote commented May 11, 2023

This comment was marked as outdated.

This comment was marked as outdated.

gyohuangxin commented Jun 6, 2023

Revolyssup commented Jun 6, 2023 • edited

theBeginner86 commented Jun 6, 2023

gyohuangxin commented Jun 7, 2023

theBeginner86 commented Jun 8, 2023 • edited

theBeginner86 commented Jun 9, 2023

theBeginner86 commented Jun 9, 2023

theBeginner86 commented Jun 9, 2023

theBeginner86 commented Jun 9, 2023

gyohuangxin commented Jun 11, 2023

theBeginner86 commented Jun 11, 2023

gyohuangxin commented Jun 12, 2023

Revolyssup commented Jun 12, 2023

Revolyssup commented Jun 12, 2023

gyohuangxin commented Jun 12, 2023

ayushthe1 commented Apr 28, 2023 •

edited

Revolyssup commented Jun 6, 2023 •

edited

theBeginner86 commented Jun 8, 2023 •

edited