Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added installation #8

Merged
merged 1 commit into from Oct 29, 2020
Merged

added installation #8

merged 1 commit into from Oct 29, 2020

Conversation

kumarabd
Copy link
Contributor

@kumarabd kumarabd commented Oct 29, 2020

Signed-off-by: kumarabd abishekkumar92@gmail.com

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: kumarabd <abishekkumar92@gmail.com>
@welcome
Copy link

welcome bot commented Oct 29, 2020

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@leecalcote leecalcote self-requested a review October 29, 2020 18:10
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failing...

@leecalcote leecalcote merged commit 43d5207 into master Oct 29, 2020
@welcome
Copy link

welcome bot commented Oct 29, 2020

Thanks for your contribution to the Layer5 community! 🎉

Congrats!

@leecalcote
Copy link
Member

@HeroicHitesh would you mind opening an issue and fixing the relative path for the welcome image above?

@kushthedude kushthedude deleted the kumarabd/feature/install branch October 30, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants