Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SMPModel in /templates/meshmodel #46

Merged
merged 7 commits into from
Mar 7, 2024
Merged

Add SMPModel in /templates/meshmodel #46

merged 7 commits into from
Mar 7, 2024

Conversation

gyohuangxin
Copy link
Member

Description

This PR related to #27 (comment)

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@gyohuangxin
Add SMPModel in /templates/meshmodel
dc8f58a 
Signed-off-by: Xin Huang <xin1.huang@intel.com>
@gyohuangxin
Copy link
Member Author

@MUzairS15 @leecalcote This is the initial PR based on my understanding, I don't know if it is correct, please forgive me I haven't figured out the Meshery Model very well, please correct me if I'm wrong. Thanks!

@leecalcote
Copy link
Member

I'm very excited about this, @gyohuangxin. 😀

@github-actions github-actions bot added area/ci Continuous integration | Build and release area/lifecycle Lifecycle management (install, uninstall, configure) related and removed component/nighthawk labels Feb 28, 2024
@leecalcote
chore: update workflows to go 1.22
1c7b9c5 
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
@leecalcote
Copy link
Member

We're in need of having RegisterMeshModelComponents changed to RegisterMeshModelComponents inside of the Meshery Adapter Library. Let's do what we can to get away from MeshModel over to Model.

@leecalcote leecalcote mentioned this pull request Feb 28, 2024
Closed
MUzairS15
MUzairS15 reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@MUzairS15 MUzairS15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see the progress, @gyohuangxin.
The definitions violate the component definition schemas defined in meshery/schemas.

@MUzairS15
Copy link
Contributor

I will update the components so that we can move forward.

@gyohuangxin
Copy link
Member Author

@MUzairS15 Thanks for your help!

MUzairS15 and others added 2 commits March 7, 2024 01:54
gyohuangxin
gyohuangxin commented Mar 7, 2024
View reviewed changes
Copy link
Member Author

@gyohuangxin gyohuangxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MUzairS15 I see you changed the metadata.json and deleted the service_mesh_performance.json, do we should need to change or delete the service_mesh.json?

@MUzairS15
Copy link
Contributor

Oh yes, I missed that.

@MUzairS15
fix model
03e272b 
Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
@MUzairS15 MUzairS15 merged commit 4d459d2 into meshery:master Mar 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MUzairS15 MUzairS15 MUzairS15 approved these changes

Assignees
No one assigned
Labels
area/ci Continuous integration | Build and release area/lifecycle Lifecycle management (install, uninstall, configure) related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gyohuangxin @leecalcote @MUzairS15