-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SMPModel in /templates/meshmodel #46
Conversation
Signed-off-by: Xin Huang <xin1.huang@intel.com>
@MUzairS15 @leecalcote This is the initial PR based on my understanding, I don't know if it is correct, please forgive me I haven't figured out the Meshery Model very well, please correct me if I'm wrong. Thanks! |
I'm very excited about this, @gyohuangxin. 😀 |
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
We're in need of having |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see the progress, @gyohuangxin.
The definitions violate the component definition schemas defined in meshery/schemas.
I will update the components so that we can move forward. |
@MUzairS15 Thanks for your help! |
Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MUzairS15 I see you changed the metadata.json and deleted the service_mesh_performance.json, do we should need to change or delete the service_mesh.json?
Oh yes, I missed that. |
Description
This PR related to #27 (comment)
Notes for Reviewers
Signed commits