Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the test coverage from 20% to 49% #461

Merged
merged 3 commits into from
May 1, 2023
Merged

Increase the test coverage from 20% to 49% #461

merged 3 commits into from
May 1, 2023

Conversation

Aisuko
Copy link
Member

@Aisuko Aisuko commented Apr 30, 2023

Description

This PR fixes #

Notes for Reviewers

I am working on increasing the test coverage for the mesheryctl and it is a good chance for us to increase coverage for the meshery-operator.

Signed commits

  • Yes, I signed my commits.

@Aisuko
Increase the test coverage to 49%
a6f0e4c 
Signed-off-by: Aisuko <urakiny@gmail.com>
@Aisuko Aisuko added the language/go Golang related label Apr 30, 2023
leecalcote
leecalcote approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. These tests aren't making any specific assertions, but are verifying the presences of Meshery Operator's custom resource definitions. 👍

@leecalcote leecalcote added the area/tests Tests label May 1, 2023
@Aisuko
Copy link
Member Author

Aisuko commented May 1, 2023 •
edited
Loading

LGTM. These tests aren't making any specific assertions, but are verifying the presences of Meshery Operator's custom resource definitions. 👍

Yes, these test cases are useful when we want to add new fields to the CRDs or check the compatibility for specific versions of Kubernetes. And the next step we are trying to add test cases for Reconcile function.

@Aisuko Aisuko merged commit 9696934 into master May 1, 2023
3 checks passed
@Aisuko Aisuko deleted the feat/test-coverage branch May 1, 2023 05:10
@Aisuko
Copy link
Member Author

Aisuko commented May 11, 2023

#463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote approved these changes

@acald-creator acald-creator Awaiting requested review from acald-creator

Assignees
No one assigned
Labels
area/tests Tests language/go Golang related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aisuko @leecalcote