Add suitest for controller #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This time we increased code coverage for controllers from 0% to 22.8% And we also update the CI process, every new PR will run all the test cases and code coverage. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #473 +/- ##
===========================================
- Coverage 45.35% 33.86% -11.49%
===========================================
Files 3 6 +3
Lines 183 375 +192
===========================================
+ Hits 83 127 +44
- Misses 95 241 +146
- Partials 5 7 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
HI, guys. Shall we merge this one? |
Azanul
reviewed
May 17, 2023
api/v1alpha1/meshsync_types_test.go
Outdated
| @@ -94,28 +94,6 @@ var _ = Describe("The test case for the meshsync CRDs", func() { | |||
| Expect(meshSyncGet.Spec.Size == 5).Should(BeTrue()) | |||
| }) | |||
|
|
|||
| It("The meshsync CRDs update the status of the resources", func() { | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Nice catch, I check this one and add it back.
There was a problem hiding this comment.
@Azanul Can we merge this now?
Signed-off-by: Aisuko <urakiny@gmail.com>
Aisuko
force-pushed
the
feat/reconcile_coverage
branch
from
33e2d3c
to
7dd63cd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Azanul
approved these changes
May 18, 2023
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR relates to #463
Notes for Reviewers
Signed commits