Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/reconcile coverage #481

Merged
merged 2 commits into from
May 19, 2023
Merged

Conversation

Micost
Copy link
Contributor

@Micost Micost commented May 19, 2023

Description

This PR is related to #463

Notes for Reviewers
add suit test for mesh sync controller

Signed commits

  • Yes, I signed my commits.

@Aisuko Aisuko self-requested a review May 19, 2023 02:52
@Aisuko Aisuko self-assigned this May 19, 2023
@Aisuko Aisuko added area/tests Tests language/go Golang related labels May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: +12.26 🎉

Comparison is base (6383cbf) 33.86% compared to head (7af8344) 46.13%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #481       +/-   ##
===========================================
+ Coverage   33.86%   46.13%   +12.26%     
===========================================
  Files           6        6               
  Lines         375      375               
===========================================
+ Hits          127      173       +46     
+ Misses        241      191       -50     
- Partials        7       11        +4     
Flag Coverage Δ
unittests 46.13% <ø> (+12.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/error.go 25.00% <ø> (+8.33%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@Aisuko Aisuko merged commit 8bcbb24 into meshery:master May 19, 2023
8 checks passed
@welcome
Copy link

welcome bot commented May 19, 2023

        Thank you for contributing to the Layer5 community! 🎉 \ \ Meshery Logo \ \         ⭐ Please leave a star on the project. 😄

@Aisuko
Copy link
Member

Aisuko commented May 19, 2023

@Micost Thank you. There are other packages that need test-cases, which you can continue if you want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Tests language/go Golang related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants