Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add suit test casses for broker #484

Merged
merged 1 commit into from
May 22, 2023
Merged

feat: add suit test casses for broker #484

merged 1 commit into from
May 22, 2023

Conversation

Aisuko
Copy link
Member

@Aisuko Aisuko commented May 19, 2023

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Aisuko <urakiny@gmail.com>
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: +2.72 🎉

Comparison is base (27d580f) 46.13% compared to head (6b04fc2) 48.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
+ Coverage   46.13%   48.85%   +2.72%     
==========================================
  Files           6        8       +2     
  Lines         375      438      +63     
==========================================
+ Hits          173      214      +41     
- Misses        191      209      +18     
- Partials       11       15       +4     
Flag Coverage Δ
unittests 48.85% <33.33%> (+2.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/broker_controller.go 49.38% <0.00%> (ø)
controllers/meshsync_controller.go 50.57% <0.00%> (ø)
pkg/broker/broker.go 74.54% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Aisuko Aisuko merged commit 5e41231 into master May 22, 2023
5 of 6 checks passed
@Aisuko Aisuko deleted the feat/mock branch May 22, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant