Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meshery broker description #514

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Add meshery broker description #514

merged 2 commits into from
Sep 5, 2023

Conversation

pewpewnor
Copy link
Contributor

@pewpewnor pewpewnor commented Aug 30, 2023

Description

This PR adds meshery broker description from https://docs.meshery.io/concepts/architecture/broker to resolve issue #509

Notes for Reviewers

Please let me know if the description needs to be edited or anything else. Thank you.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Norbert Oliver <newpatchnotworking2@tutanota.com>
@welcome
Copy link

welcome bot commented Aug 30, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5e8af38) 50.22% compared to head (e727771) 50.22%.

❗ Current head e727771 differs from pull request most recent head 11af1ee. Consider uploading reports for the commit 11af1ee to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #514   +/-   ##
=======================================
  Coverage   50.22%   50.22%           
=======================================
  Files           9        9           
  Lines         450      450           
=======================================
  Hits          226      226           
  Misses        209      209           
  Partials       15       15           
Flag Coverage Δ
unittests 50.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


# Meshery Broker
Meshery Broker is a custom Kubernetes controller that provides data streaming across independent components of Meshery whether those components are running inside or outside of the Kubernetes cluster.
<br />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pewpewnor Thanks for this, will you also add a link reference to this slide (45, 46, and 47 talks about broker) for Meshery Broker? https://docs.google.com/presentation/d/1SQMfyu5shjpGKlYONdVzOtd7UYTgLWBcgUvHMLCZ2tY/edit#slide=id.g10af036b3dd_0_0

Copy link
Contributor Author

@pewpewnor pewpewnor Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, I'll just convert the "meshery broker" to reference the link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it has been done in this commit

@Ghat0tkach
Copy link
Member

Thanks for this @pewpewnor , Please do the changes as suggested by @Chadha93

Copy link
Member

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved cc @leecalcote

Signed-off-by: Norbert Oliver <newpatchnotworking2@tutanota.com>
Copy link
Member

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aisuko Aisuko merged commit ddb1f7d into meshery:master Sep 5, 2023
3 checks passed
@welcome
Copy link

welcome bot commented Sep 5, 2023

        Thank you for contributing to the Layer5 community! 🎉 \ \ Meshery Logo \ \         ⭐ Please leave a star on the project. 😄

@Aisuko
Copy link
Member

Aisuko commented Sep 5, 2023

@pewpewnor Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants