Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove circular dependencies #536

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Remove circular dependencies #536

merged 1 commit into from
Oct 17, 2023

Conversation

Aisuko
Copy link
Member

@Aisuko Aisuko commented Oct 16, 2023

Description

This PR fixes #

Notes for Reviewers

Currently, meshkit import meshery-operator as a dependency https://github.com/meshery/meshkit/blob/2139daa803facbfca54860e879033b8613669773/go.mod#L22

And meshery-operator import meshkit as a dependency.

So, here is a circular dependencies. And this can be avoided and it should be avoided. It can lead to various issues, including * compilation errors

  • increased complexity
  • reduced maintainability of projects

Signed commits

  • Yes, I signed my commits.

@Aisuko Aisuko changed the title Remove dependency cycle Remove circular dependencies Oct 16, 2023
@Aisuko Aisuko added the language/go Golang related label Oct 16, 2023
@Aisuko Aisuko force-pushed the fix/security branch 2 times, most recently from 6551627 to a4100c3 Compare October 16, 2023 07:25
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (e76bb7f) 50.22% compared to head (cc4af68) 49.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
- Coverage   50.22%   49.70%   -0.52%     
==========================================
  Files           9        9              
  Lines         450      513      +63     
==========================================
+ Hits          226      255      +29     
- Misses        209      236      +27     
- Partials       15       22       +7     
Flag Coverage Δ
unittests 49.70% <45.97%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controllers/broker_controller.go 30.86% <ø> (-18.52%) ⬇️
controllers/error.go 100.00% <100.00%> (+75.00%) ⬆️
controllers/meshsync_controller.go 50.57% <ø> (ø)
pkg/broker/error.go 100.00% <100.00%> (+100.00%) ⬆️
pkg/broker/broker.go 49.13% <31.88%> (-25.41%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: GitHub <noreply@github.com>
@leecalcote leecalcote merged commit dcc2130 into master Oct 17, 2023
4 of 6 checks passed
@leecalcote leecalcote deleted the fix/security branch October 17, 2023 12:31
@Aisuko Aisuko self-assigned this Oct 30, 2023
@Aisuko Aisuko mentioned this pull request Oct 30, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/go Golang related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants