Replaced Layer5 logo with Meshery in config.yml #286
Conversation
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
|
Thanks for creating a PR. Please sign-off the commits using |
Signed-off-by: @Amukayoung <amukayoung@gmail.com>
Signed-off-by: @Amukayoung <amukayoung@gmail.com>
.github/config.yml
Outdated
| @@ -17,7 +17,11 @@ newPRWelcomeComment: > | |||
| firstPRMergeComment: > | |||
| Thanks for your contribution to the Layer5 community! :tada: | |||
There was a problem hiding this comment.
| Thanks for your contribution to the Layer5 community! :tada: | |
| Thanks for your contribution to Meshery! :tada: |
.github/config.yml
Outdated
| <source media="(prefers-color-scheme: dark)" srcset="./assets/images/welcome/meshery-welcome-logo-light-text-side.svg"> | ||
| <source media="(prefers-color-scheme: light)" srcset="./assets/images/welcome/meshery-welcome-logo-dark-text-side.svg"> |
There was a problem hiding this comment.
Better use the raw URLs for images, also rename the images to Meshery-celebration-Dark.svg and Meshery-celebration-Light.svg to keep the uniformity of name conventions
There was a problem hiding this comment.
Also, the dimensions of the images are larger than needed, use these
There was a problem hiding this comment.
Thanks for these reviews. Let me fix it and confirm with you
There was a problem hiding this comment.
Thanks @thisiskaransgit You can review the changes again. In case of any adjustment, please let me know
Signed-off-by: @Amukayoung <amukayoung@gmail.com>
.github/config.yml
Outdated
| <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/meshery/meshery-traefik-mesh/master/.github/assets/images/welcome/meshery-welcome-logo-light-text-side.svg"> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/meshery/meshery-traefik-mesh/master/.github/assets/images/welcome/meshery-welcome-logo-dark-text-side.svg"> |
There was a problem hiding this comment.
@Amukayoung, wrong name of files in the path
There was a problem hiding this comment.
Also, update the images with the one I provided
There was a problem hiding this comment.
Oh sorry, let me handle it thanks
There was a problem hiding this comment.
I have just updated the logos with a small one of 300 x 51 px and equally corrected their names in the path. Please in case of any further changes, you can let me know. Thanks @thisiskaransgit
There was a problem hiding this comment.
@Amukayoung, there's still too much extra space identifiable in the image, doesn't look like you have updated them, check again.
There was a problem hiding this comment.
@thisiskaransgit Thanks for the feedback. Please kindly check the two sets of logos shared because it looks like they are all the same. Actually, I have downloaded and updated the path with the second set of logos (The one you shared here in this conversation)
Signed-off-by: @Amukayoung <amukayoung@gmail.com>
Description
This PR replaces the Layer5 logo with Meshery in config.yml #278
Notes for Reviewers
Am readily available for any adjustment
Signed commits