Font sizes fixed and styling improvements #746
Conversation
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Meshery Contributors' Welcome Guide and sure to join the community Slack. |
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Sure @debo19, than can be done. I thought the font part is fine for the rest of the part,(because it was even, one shape and size), except the Getting started, where the font was noticeably smaller. But if you want me to push a Global fix, sure it can be done. |
|
The image below is in a bigger font, same size which has been the largest for |
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
|
@debo19 /other maintainers please review the recent commit and let me know if there is anything else that is to be changed. 😊 |
There was a problem hiding this comment.
@debo19 don't you think the font size is a little too big now? 😅 or it might just be that I'm used to seeing the old size
|
@warunicorn19 even I think so, I can make it a little smaller, but then there wouldnt be a huge difference between the previous and the current version. 😅 |
Co-authored-by: Debopriya Bhattacharjee <85789734+debo19@users.noreply.github.com> Signed-off-by: warunicorn19 <speak2adi@gmail.com>
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
There was a problem hiding this comment.
@eeshaanSA On the catalog pages, the heading looks smaller than the subtexts now. Maybe switch the <h4> with <h3>? Everything else looks good.
|
can be done, @debo19, but if we change the heading to an h3, the main title, i.e (circuit breaker) will have to be an h2. Is there a workaround? |
|
|
|
Looks good @eeshaanSA |
|
Thanks for the confirmation. I recently noticed this issue is also seen on the respective pages of the patterns, where the heading looks kind of smaller than the paragraph. I will correct them as well, though I leave it up to you for the final call. @debo19 @warunicorn19 |
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
|
@eeshaanSA please please please stop tagging me. |
|
@debo19 please have a look. |
Signed-off-by: Eeshaan Sawant <eeshaans1@gmail.com>
|
@eeshaanSA will you address the merge conflict here, then this will be good to go |
Signed-off-by: Debopriya Bhattacharjee <85789734+debo19@users.noreply.github.com>
|
Thanks for your contribution to the Layer5 and Meshery community! 🎉
|
Signed-off-by: Eeshaan Sawant eeshaans1@gmail.com
Description
Fixed Font sizes at various places and did some styling improvements.
This PR fixes #740
Notes for Reviewers
Always open for suggestions and improvements. Please point me out if anything should be added/corrected.
Signed commits