Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the box shadow of performance tests run #1136

Merged
merged 6 commits into from May 23, 2023

Conversation

Savio629
Copy link
Contributor

Description
Fixed the box shadow of performance test run

This PR fixes #905

Screenshots
Before :

Features._.Meshery.-.Brave.2023-04-21.22-18-35.mp4

After :

Features._.Meshery.-.Brave.2023-04-21.22-19-33.mp4

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Savio629 <diassavio629@gmail.com>
@netlify
Copy link

netlify bot commented Apr 21, 2023

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 6ce7495
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/646c8cc85f97e30008c8aee4
😎 Deploy Preview https://deploy-preview-1136--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Savio629
Copy link
Contributor Author

Copy link
Contributor

@GaganpreetKaurKalsi GaganpreetKaurKalsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Contributor

@thisiskaransgit thisiskaransgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Savio629 The change looks good, remove the white space and we are good to go

@Savio629
Copy link
Contributor Author

@thisiskaransgit
You mean to decrease the box width?

@@ -171,7 +171,7 @@ <h2 style="margin: 0">Use the <span class="special-text">Service Mesh Performanc
});
</script>
<div class="flex"
style="box-shadow: 0px 0px 20px 3px rgba(71,126,150,.5);margin-top: 20px; display: flex; align-items: center; justify-content: center; clear:both; height: 40px;border-radius: 10px; margin:auto; width:90%; margin-top: 11px;">
style=" box-shadow: var(--box-shadow-primary);margin-top: 20px; display: flex; align-items: center; justify-content: center; clear:both; height: 40px;border-radius: 10px; margin:auto; width:90%; margin-top: 11px;">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
style=" box-shadow: var(--box-shadow-primary);margin-top: 20px; display: flex; align-items: center; justify-content: center; clear:both; height: 40px;border-radius: 10px; margin:auto; width:90%; margin-top: 11px;">
style="box-shadow: var(--box-shadow-primary);margin-top: 20px; display: flex; align-items: center; justify-content: center; clear:both; height: 40px;border-radius: 10px; margin:auto; width:90%; margin-top: 11px;">

@Savio629 :)

Signed-off-by: Savio629 <diassavio629@gmail.com>
@Savio629
Copy link
Contributor Author

@thisiskaransgit done :)

Copy link
Contributor

@thisiskaransgit thisiskaransgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge, thank you for your contribution 🎉

@leecalcote leecalcote merged commit 6b9b815 into meshery:master May 23, 2023
7 checks passed
@Savio629 Savio629 deleted the box-shadow1 branch June 9, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change current box shadow.
4 participants