Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate-and-fix-community-page-sections #1344

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

vishalvivekm
Copy link
Member

@vishalvivekm vishalvivekm commented Aug 1, 2023

Description

This PR fixes #1271

Notes for Reviewers

An.Open.Source.Community._.Meshery.-.Google.Chrome.2023-08-01.22-56-49.mp4

Signed commits

  • Yes, I signed my commits.

Signed-off-by: vishalvivekm <110674407+vishalvivekm@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit b765da6
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/64c94783c6e0e50008f42017
😎 Deploy Preview https://deploy-preview-1344--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishalvivekm
Copy link
Member Author

Take a look folks!
Section1 - @Gautam-04
Section2- @Ykumar1415
Section3- @Mohith234
Section4- @ranjanmangla1
Section5- @lanzkrish
Section6- @ayushsinha25

@ritiksaxena124
Copy link
Contributor

Thank you @Gautam-04, @Ykumar1415, @Mohith234, @ranjanmangla1, @lanzkrish, and @ayushsinha25 for your contribution. The page looks great. You guys did great work 👌

Some changes are needed that I have mentioned below:

  1. Reduce the height of the hero section
  2. Text hard to read in the "Meshery Community Meetings and Events" section
  3. MeshMate logo and Community calendar image fails the quality check
  4. Community Handbook cover looks like it is stretched
  5. Don't use text-align: justify. doesn't look good in mobile view
    image
  6. Circle behind the icon is not a proper circle
    image
  7. Icon hard to see
    image

@Mohith234
Copy link
Member

@ritiksaxena124 Regarding the Handbook section,

  • Is it looking stretched vertically? Should I reduce the height a bit?

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritiksaxena124 has shared very good points that need to be addressed but first lets merge this and make other issues for all improvements related to it since we need all info on the page quick

@Chadha93 Chadha93 merged commit 007b9d0 into meshery:master Aug 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New page design implementation for Contributors page
5 participants