[Catalog] Text and Modal chip alignment colour fixed #965
Conversation
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@leecalcote @GaganpreetKaurKalsi Please review the changes. |
|
@leecalcote Please review it. |
MrBehl06
force-pushed
the
TextColor
branch
2 times, most recently
from
9f4ca73
to
9c4adaa
Compare
github-actions
bot
added
area/docs
|
@leecalcote @GaganpreetKaurKalsi Please help me why there is an error and test failure in this pr. |
|
@MrBehl06 because one of the commits isn't signed off (follow the instructions provide for a permanent solution. follow these for this PR - https://github.com/meshery/meshery.io/pull/965/checks?check_run_id=10744634801). Also, this PR has a number of other people's commits that are likely included unintentionally (resync your fork). |
|
A couple of merge conflicts have arisen. |
|
Okey @leecalcote thank you. |
Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: Sreya Gadepally <sreya@Sreyas-MacBook-Pro.local> Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: Sreya Gadepally <sreyagadepally@gmail.com> Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: l5io <ci@layer5.io> Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in> Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: l5io <ci@layer5.io> Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: l5io <ci@layer5.io> Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: Shivam-AfA <shivamsood634@gmail.com> Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: l5io <ci@layer5.io> Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
There was a problem hiding this comment.
@MrBehl06 Follow these instructions to sync your fork - https://github.com/meshery/meshery/blob/master/docs/CONTRIBUTING-gitflow.md#fetch-upstream-master-and-merge-with-your-repos-master-branch
Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
github-actions
bot
removed
area/website
area/docs
Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
Signed-off-by: SandeepBehl <101118926+MrBehl06@users.noreply.github.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
|
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
Signed-off-by: Sandeep Behl sandeepbhel05@gmail.com
Description
Current State
Desired State :
This PR fixes #
These are the following issues fixed in this PR:
1)Text colour and aligned fixed of the modal name.
2)Modal-pattern-image aligned with the text.
3)Modal-chip aligned and colour fixed.
4)em, strong, span colours set according to night mode and dark mode
Notes for Reviewers
Signed commits