Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] React Warnings in Meshery UI Build #10254

Closed
leecalcote opened this issue Feb 8, 2024 · 2 comments
Closed

[UI] React Warnings in Meshery UI Build #10254

leecalcote opened this issue Feb 8, 2024 · 2 comments
Assignees
Labels
component/ui User Interface framework/react good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working language/javascript Issues or pull requests that use Javascript or React

Comments

@leecalcote
Copy link
Member

Current Behavior

While building Meshery UI, the following warnings are shown.

Desired Behavior

No warnings during make ui-build (no build warnings).

Screenshots/Logs

./components/MesheryMeshInterface/PatternService/CustomTextTooltip.js
16:19  Warning: React Hook "useStyles" is called in function "renderTooltipContent" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use".  react-hooks/rules-of-hooks

./components/connections/index.js
987:5  Warning: React Hook "useUpdateConnectionMutator" is called in function "updateConnectionStatus" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use".  react-hooks/rules-of-hooks

./components/hooks/useTelemetryHook.js
18:22  Warning: React Hook "useNotification" is called in function "pingPrometheus" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use".  react-hooks/rules-of-hooks
19:20  Warning: React Hook "useDispatch" is called in function "pingPrometheus" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use".  react-hooks/rules-of-hooks
43:22  Warning: React Hook "useNotification" is called in function "pingGrafana" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use".  react-hooks/rules-of-hooks
44:20  Warning: React Hook "useDispatch" is called in function "pingGrafana" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use".  

Contributor Guides and Handbook

@leecalcote leecalcote added kind/bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers language/javascript Issues or pull requests that use Javascript or React component/ui User Interface framework/react labels Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@MeenuyD
Copy link
Contributor

MeenuyD commented Feb 9, 2024

Hello @leecalcote I would like to work on this issue can you please assign it to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface framework/react good first issue Good for newcomers help wanted Extra attention is needed kind/bug Something isn't working language/javascript Issues or pull requests that use Javascript or React
Projects
None yet
Development

No branches or pull requests

3 participants