Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #155 TextAlign Center #176

Merged
merged 1 commit into from Feb 8, 2024
Merged

Conversation

ayusudi
Copy link
Contributor

@ayusudi ayusudi commented Jan 10, 2024

Notes for Reviewers

This PR fixes #155

Signed commits

  • Yes, I signed my commits.

Signed-off-by: ayusudi <ayusudi.abc@gmail.com>
Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for meshery-play ready!

Name Link
🔨 Latest commit 5412493
🔍 Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/659eb43ddd23cc0008a25186
😎 Deploy Preview https://deploy-preview-176--meshery-play.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ayusudi
Copy link
Contributor Author

ayusudi commented Jan 10, 2024

The update
image
image

Copy link
Member

@sandramsc sandramsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayusudi
Copy link
Contributor Author

ayusudi commented Jan 23, 2024

Hello @sandramsc , I hope this message finds you well. I'm currently unsure about the next steps, and I wanted to reach out to you regarding the review stage. If you have any specific input or guidance, please let me know..

Additionally, if there are any further frontend tasks that I can assist with, I would be more than happy to do so. Thank you for your support 🚀

@sandramsc
Copy link
Member

Hello @sandramsc , I hope this message finds you well. I'm currently unsure about the next steps, and I wanted to reach out to you regarding the review stage. If you have any specific input or guidance, please let me know..

Additionally, if there are any further frontend tasks that I can assist with, I would be more than happy to do so. Thank you for your support 🚀

Hi @ayusudi , so great that you are motivated and eager to continue contributing! Generally, once a PR has been made contributors and maintainers alike take a look and submit a review either requesting changes or approving the PR. The time within which this happens varies as maintainers are usually very occupied, but do make it a priority to review PR's at their earliest convenience.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sandramsc!

Thanks, @ayusudi! @ayusudi, here's an issue that needs help - meshery/meshery#10254

@leecalcote leecalcote merged commit f151cfe into meshery:master Feb 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UX - Responsiveness] Learn - text alignment not consistent
3 participants