Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Broken image link in Provider modal. #10909

Closed
MUzairS15 opened this issue May 9, 2024 · 3 comments · Fixed by #10919
Closed

[UI] Broken image link in Provider modal. #10909

MUzairS15 opened this issue May 9, 2024 · 3 comments · Fixed by #10919
Assignees
@SparshDusad
Labels
component/ui User Interface good first issue Good for newcomers help wanted Extra attention is needed issue/willfix This issue will be worked on kind/bug Something isn't working

Comments

@MUzairS15
Copy link
Contributor

MUzairS15 commented May 9, 2024 •
edited by leecalcote

Current Behavior

The "About Providers" modal has a broken image.

Screen.Recording.2024-05-09.at.9.38.58.PM.mov

Expected Behavior

An external link image should be displayed.

Contributor Guides and Handbook
@MUzairS15 MUzairS15 added the kind/bug Something isn't working label May 9, 2024
@leecalcote leecalcote added help wanted Extra attention is needed component/ui User Interface good first issue Good for newcomers labels May 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@SparshDusad
Copy link
Contributor

SparshDusad commented May 10, 2024 •
edited

@leecalcote Assign this issue to me!
Sparsh_
Fixed it! Just give me permission to create a merge request.

@sandramsc
Copy link
Member

sandramsc commented May 10, 2024 •
edited

Hi @SparshDusad since you were the first to request assignment, you've got it! Also please remember to take a look at the CONTRIBUTING.md if you have not already.

SparshDusad referenced this issue May 10, 2024
@SparshDusad
Your commit message
cc7a7f6 
Signed-off-by: Sparsh Dusad <sparshdusad007@gmail.com>
Signed-off-by: SparshDusad <sparshdusad007@gmail.com>
@SparshDusad SparshDusad mentioned this issue May 10, 2024
Closed
1 task
SparshDusad added a commit to SparshDusad/meshery that referenced this issue May 10, 2024
@SparshDusad
meshery#10909
7ddc9f5 
Signed-off-by: SparshDusad <sparshdusad007@gmail.com>
@SparshDusad SparshDusad mentioned this issue May 10, 2024
Merged
1 task
@leecalcote leecalcote added the issue/willfix This issue will be worked on label May 10, 2024
nebula-aac added a commit that referenced this issue May 11, 2024
@nebula-aac
Merge pull request #10919 from SparshDusad/master
690b50d 
[UI] Broken image link in Provider modal. #10909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SparshDusad SparshDusad

Labels
component/ui User Interface good first issue Good for newcomers help wanted Extra attention is needed issue/willfix This issue will be worked on kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@leecalcote @sandramsc @MUzairS15 @SparshDusad