Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mesheryctl] revert interactive y/n mesheryctl version question #2099

Closed
leecalcote opened this issue Dec 16, 2020 · 3 comments · Fixed by #2108
Closed

[mesheryctl] revert interactive y/n mesheryctl version question #2099

leecalcote opened this issue Dec 16, 2020 · 3 comments · Fixed by #2108
Assignees
Labels
component/mesheryctl CLI for Meshery kind/bug Something isn't working language/go Issues or pull requests that use Golang

Comments

@leecalcote
Copy link
Member

Description

➜  ~ mesheryctl version
Client Version: v0.4.15 	  GitSHA: 51ca056186a824ad1c2b1bf979b95bdc46978d34
Server Version: unavailable 	  GitSHA: unavailable

Unable to communicate with Meshery: Get http://localhost:9081/api/server/version: dial tcp [::1]:9081: connect: connection refused
Ensure that Meshery is available, see Meshery Documentation (https://docs.meshery.io) for more help.

Checking for latest version of Meshery....

v0.4.15 is not the latest Meshery release. Update to v0.4.27. Run `mesheryctl system update`
Use the arrow keys to navigate: ↓ ↑ → ←
? Would you like to upgrade to v0.4.27 now?(y/n):
  ▸ y
    n

Expected Behavior
The interactive y / n question is unexpected and not a universal user experience (not consistent with how users are prompted with y/n in other commands). User prompts should be consistent in style. Please update mesheryctl version to prompt with:

Would you like to upgrade to v0.4.27 now (y/n)? 
@leecalcote leecalcote added kind/bug Something isn't working component/mesheryctl CLI for Meshery language/go Issues or pull requests that use Golang labels Dec 16, 2020
@leecalcote
Copy link
Member Author

@uds5501 are you interested in taking this one?

@uds5501
Copy link
Contributor

uds5501 commented Dec 16, 2020

@leecalcote I will take this one, should be a small change.

@uds5501 uds5501 self-assigned this Dec 16, 2020
@leecalcote
Copy link
Member Author

Thank you, @uds5501 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mesheryctl CLI for Meshery kind/bug Something isn't working language/go Issues or pull requests that use Golang
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants