Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mesheryctl] Revert interactive prompt to classic y/n #2108

Merged
merged 4 commits into from Dec 21, 2020
Merged

[mesheryctl] Revert interactive prompt to classic y/n #2108

merged 4 commits into from Dec 21, 2020

Conversation

uds5501
Copy link
Contributor

@uds5501 uds5501 commented Dec 17, 2020

Signed-off-by: Uddeshya Singh singhuddeshyaofficial@gmail.com

Description
Reverts the interactive prompt to classic y/n form

This PR fixes #2099

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Uddeshya Singh <singhuddeshyaofficial@gmail.com>
@probot-autolabeler probot-autolabeler bot added component/api Issues related to API language/go Issues or pull requests that use Golang labels Dec 17, 2020
@netlify
Copy link

netlify bot commented Dec 17, 2020

✔️ Deploy preview for meshery-docs ready!

🔨 Explore the source changes: 42e1738

🔍 Inspect the deploy logs: https://app.netlify.com/sites/meshery-docs/deploys/5fe11090fe82a400075c7313

😎 Browse the preview: https://deploy-preview-2108--meshery-docs.netlify.app

Signed-off-by: Uddeshya Singh <singhuddeshyaofficial@gmail.com>

"github.com/layer5io/meshery/mesheryctl/pkg/utils"

"github.com/manifoldco/promptui"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this library, please run go mod tidy after the change to remove it from deps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uds5501 I went ahead and removed this unused package.

Signed-off-by: leecalcote <leecalcote@gmail.com>
leecalcote
leecalcote previously approved these changes Dec 21, 2020

"github.com/layer5io/meshery/mesheryctl/pkg/utils"

"github.com/manifoldco/promptui"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uds5501 I went ahead and removed this unused package.

@leecalcote leecalcote merged commit fc64e82 into meshery:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api Issues related to API language/go Issues or pull requests that use Golang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mesheryctl] revert interactive y/n mesheryctl version question
3 participants