Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mesheryctl] Increase code coverage in mesheryctl upto 80% #3988

Closed
Tracked by #7805
piyushsingariya opened this issue Aug 26, 2021 · 20 comments · Fixed by #7896
Closed
Tracked by #7805

[mesheryctl] Increase code coverage in mesheryctl upto 80% #3988

piyushsingariya opened this issue Aug 26, 2021 · 20 comments · Fixed by #7896
Assignees
Labels
area/tests Testing / quality assurance component/mesheryctl CLI for Meshery issue/willfix This issue will be worked on kind/bug Something isn't working kind/chore Necessary task kind/enhancement Improvement in current feature kind/epic An issue that describes a set of concerns (issues) language/go Issues or pull requests that use Golang
Milestone

Comments

@piyushsingariya
Copy link
Contributor

Current Behavior

The current code coverage is less than 30% check here https://app.codecov.io/gh/meshery/meshery

Expected Behavior

Increase this code coverage up to 80%, this time!


Contributor Guides and Resources

@piyushsingariya piyushsingariya added kind/bug Something isn't working kind/chore Necessary task kind/enhancement Improvement in current feature kind/epic An issue that describes a set of concerns (issues) area/tests Testing / quality assurance component/mesheryctl CLI for Meshery language/go Issues or pull requests that use Golang labels Aug 26, 2021
@github-actions
Copy link

This issue has been labeled with 'component/mesheryctl'. Note that after making changes you need to update it in the mesheryctl command tracker spreadsheet.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@piyushsingariya piyushsingariya pinned this issue Aug 26, 2021
@shikharvashistha
Copy link
Contributor

Hey @piyushsingariya I would like to work on this.

@piyushsingariya piyushsingariya changed the title [mesheryctl] Increase code coverage upto 80% [mesheryctl] Increase code coverage in mesheryctl upto 80% Aug 31, 2021
@meshery meshery deleted a comment from shikharvashistha Sep 8, 2021
@meshery meshery deleted a comment from shikharvashistha Sep 8, 2021
@piyushsingariya piyushsingariya added this to the v0.9.0 milestone Oct 13, 2021
@stale
Copy link

stale bot commented Nov 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Nov 22, 2021
@piyushsingariya piyushsingariya removed the issue/stale Issue has not had any activity for an extended period of time label Nov 23, 2021
@stale
Copy link

stale bot commented Jan 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jan 2, 2022
@leecalcote
Copy link
Member

Hi @shikharvashistha, checking in on the this issue. Do you have progress to report, by chance?

@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Jan 3, 2022
@shikharvashistha
Copy link
Contributor

Hi @shikharvashistha, checking in on the this issue. Do you have progress to report, by chance?

Thanks for asking @leecalcote . As of now I don't have any progress on this issue, but would like to continue with it if possible which I was unable to due to my offline exams schedule.

@Kumaravinash9
Copy link

Kumaravinash9 commented Jan 31, 2022

Hi @leecalcote @piyushsingariya I would like to work on this issue. If someone else is working, I would like to collaborate with them. Thanks

@stale
Copy link

stale bot commented Mar 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Mar 12, 2022
@leecalcote leecalcote added issue/willfix This issue will be worked on and removed issue/stale Issue has not had any activity for an extended period of time labels Mar 12, 2022
@nishi6verma
Copy link

I am interested to contribute in this issue. Pl. give me permission. So, that I can check and try solve.

@pk-218
Copy link
Member

pk-218 commented Aug 30, 2022

@piyushsingariya @alphaX86 can I assist with this issue? I can start with mesheryctl filter subcommands.

@leecalcote
Copy link
Member

@nishi6verma @pk-218, this is great. // @alphaX86 @hexxdump

@Swathi-L
Copy link
Contributor

Hi @nishi6verma @pk-218, are you guys taking a look at it

@nishi6verma
Copy link

nishi6verma commented Feb 21, 2023 via email

@nishi6verma
Copy link

nishi6verma commented Feb 21, 2023 via email

@Aisuko
Copy link
Member

Aisuko commented Apr 10, 2023

This is not a good news. Maybe I can help on this one.

@leecalcote
Copy link
Member

Making good progress here, @Aisuko 👏

@Aisuko
Copy link
Member

Aisuko commented Jun 8, 2023

@Freedisch you can write the new test cases for mesheryctl directly. It needs new test cases that are friendly for the new contributors. There are some test cases out of date please remove them.

@Aisuko Aisuko removed their assignment Jun 8, 2023
@Freedisch
Copy link
Member

@Aisuko , got it. For the outdated test cases in reference to this issue 7821 u created

@Aisuko
Copy link
Member

Aisuko commented Jun 9, 2023

I'd like to suggest you split test cases into several PRs, it will be more effective for us merging them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Testing / quality assurance component/mesheryctl CLI for Meshery issue/willfix This issue will be worked on kind/bug Something isn't working kind/chore Necessary task kind/enhancement Improvement in current feature kind/epic An issue that describes a set of concerns (issues) language/go Issues or pull requests that use Golang
Projects
None yet
10 participants