Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Update CodeEditor to a different package #6965

Open
acald-creator opened this issue Feb 1, 2023 · 7 comments
Open

[UI] Update CodeEditor to a different package #6965

acald-creator opened this issue Feb 1, 2023 · 7 comments
Assignees
Labels
component/ui User Interface issue/willfix This issue will be worked on kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React

Comments

@acald-creator
Copy link
Contributor

Current Behavior

Currently meshery/ui is on Next.js v12 and React@17. However there is a package that will need to be removed in due time, react-codemirror2, because this package relies on React@16, and we're in need of moving to a different package.

Desired Behavior

There were some suggestions of packages:

  • @monaco-editor/react
  • monaco-editor
  • react-ace (which is already used in ui-restructuring-meshery branch)
  • codemirror

Implementation

I have already completed a couple of protoypes with codemirror and @monaco-editor/react but have not finalize this change.

Acceptance Tests

Mockups


Contributor Guides and Handbook

@acald-creator acald-creator added the kind/enhancement Improvement in current feature label Feb 1, 2023
@acald-creator acald-creator self-assigned this Feb 1, 2023
@acald-creator acald-creator added component/ui User Interface language/javascript Issues or pull requests that use Javascript or React labels Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@acald-creator acald-creator added the issue/willfix This issue will be worked on label Feb 15, 2023
@acald-creator
Copy link
Contributor Author

bump

@acald-creator
Copy link
Contributor Author

Working on this now.

Researching @uwi/react-codemirror and rodemirror with codemirror.

@acald-creator
Copy link
Contributor Author

Bump

using https://github.com/yjs/y-codemirror.next to replace the existing editor.

@nebula-aac
Copy link
Contributor

bump

@nebula-aac
Copy link
Contributor

Will be providing an update with the design spec.

@sandramsc
Copy link
Member

Hi @nebula-aac @acald-creator are you still intend to work on this issue? Let us know so we know to allow you more time, otherwise, we'll need to free (unassign you) the issue so as to allow other contributors to give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface issue/willfix This issue will be worked on kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React
Projects
None yet
Development

No branches or pull requests

3 participants