New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Migrate to @reduxjs/toolkit
tracker
#7207
Comments
This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.
|
Hi @acald-creator! I would like to work on this. |
@roopeshsn Awesome Thanks for reaching out. This migration tracker is aiming for It is quite possible to achieve this sooner but I will be updating this issue as time goes by to list some of the changes that will needs to be made. In the meantime, you can still help and provide insights if you have any. |
Sure, @acald-creator! Let me see the existing implementation of react-redux and provide insights if any. |
This issue has been labeled with 'design-required'. Note that prior to commencing on implementation, a design specification needs to be created and reviewed for approval. See Creating a Functional Specification to create a design spec.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
bump |
@nebula-aac I would like to work on this issue |
bump |
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
|
bump |
bump again, updated this issue |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
|
UPDATE There is an open PR and open issue to track migrating Meshery UI to the latest libraries and using the latest styles and components from the Sistent Design System.
Open Issue: layer5io/sistent#496
Open PR: layer5io/sistent#498
In the open PR, I've already started work on using the
@reduxjs/toolkit
store. But they are not tested very well because of needing to make sure that the Provider's login works correctly before authenticating and redirecting back to the homepage.UPDATE This milestone has been pushed back to
v7
only because we have couple of tickets that are asking for React Class to Function components conversion, and this is impacted because using the existing implementations ofmapStateToProps
andmapDispatchToProps
are commonly associated withconnect
HOC component withreact-redux
.Current Behavior
Redux has always been a complex library, but they've recently released a package called
@reduxjs/toolkit
which simplifies how you usereact-redux
in the app.next-redux-wrapper
has also released a newer version atv8
, which is vastly different fromv3
and also has support for@reduxjs/toolit
.After some research, I found that is best to not just use Redux as the only global state management package for Meshery.
I would like to point out other packages that can be of use with Redux, or without Redux.
jotai
xstate
zustand
mobx
Desired Behavior
This is an open issue to track progress after certain milestones occur.
ui
#7212Implementation
@reduxjs/toolkit
Create Theme Provider context to toggle light and dark themedone in forked branchResearch the current
store.js
and break it down into multiple slices.update page path and title (could be used as a custom hook)Revised to be a Context APIuseState
instead of redux (WIP)In this forked branch at https://github.com/nebula-aac/meshery/tree/feat/reduxjs-toolkit-migration, here are the list of features within the Redux store that will be implemented. Please note that these are in progress and already created in the forked branch.
Acceptance Tests
Mockups
Contributor Guides and Handbook
The text was updated successfully, but these errors were encountered: