Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Wrap Provider UI as an React Context in ui #7212

Open
acald-creator opened this issue Feb 27, 2023 · 12 comments
Open

[UI] Wrap Provider UI as an React Context in ui #7212

acald-creator opened this issue Feb 27, 2023 · 12 comments
Assignees
@nebula-aac
Labels
component/ui User Interface framework/react issue/remind Issue progress check issue/willfix This issue will be worked on kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React
Milestone
v0.8.0

Comments

@acald-creator
Copy link
Contributor

acald-creator commented Feb 27, 2023 •
edited by nebula-aac

UPDATE: Moving Provider UI into a React Context has already been done in a protoype. After we make more changes to upgrade some of the deprecated packages in meshery ui, will be adding this implementation into meshery somewhere in v0.7.0

Current Behavior

Convert provider-ui into a React context to be wrapped in ui directory.

Desired Behavior

Would like to see this merged sometime in v0.7 after we're able to convert most of the React Class components to Function components.

Implementation

I will list the steps here needed to take. I have a local branch working on this.

Acceptance Tests

Mockups

Contributor Guides and Handbook
@acald-creator acald-creator added kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React component/ui User Interface framework/react labels Feb 27, 2023
@acald-creator acald-creator added this to the v0.7.0 milestone Feb 27, 2023
@acald-creator acald-creator changed the title [UI] Wrap Provider UI as an Auth Context in ui [UI] Wrap Provider UI as an React Context in ui Feb 27, 2023
@github-actions
Copy link

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@siddheshJungade
Copy link
Contributor

Hi @acald-creator can I work on this ?

@acald-creator
Copy link
Contributor Author

@siddheshJungade Hi I'm currently working on this, and there are several things that need to be done first before making this happen.

While it could happen now, it will require some clean up later.

You can keep an eye on this open issue for more information if you want.

@acald-creator acald-creator self-assigned this Feb 28, 2023
@siddheshJungade
Copy link
Contributor

Sure @acald-creator

@acald-creator
Copy link
Contributor Author

update: On a separate repo, I have a potential Authentication context that can be wrapped and merged within ui. However, to make sure that this works, some of the React Class Components need to be migrated to Function components.

@acald-creator acald-creator mentioned this issue Mar 4, 2023
Open
6 tasks
@stale
Copy link

stale bot commented Apr 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 17, 2023
@acald-creator acald-creator added issue/willfix This issue will be worked on and removed issue/stale Issue has not had any activity for an extended period of time labels Apr 18, 2023
@acald-creator acald-creator mentioned this issue Apr 29, 2023
Closed
1 task
@acald-creator
Copy link
Contributor Author

bump, still in progress

@leecalcote
Copy link
Member

Not having a separate nextjs instance will be an improvement.

@acald-creator
Copy link
Contributor Author

Yes @leecalcote

I did see that we are working towards using CASL.js, are we implementing this just in meshery/ui, or will some of this needs to be done in the provider-ui, which will be merged with ui in the near future.

@leecalcote
Copy link
Member

Yes @leecalcote

I did see that we are working towards using CASL.js, are we implementing this just in meshery/ui, or will some of this needs to be done in the provider-ui, which will be merged with ui in the near future.

Ultimately, both. Although currently, the provider UI is on authenticated, and has no need for permissions given its singular use case.

@nebula-aac
Copy link
Contributor

still in progress, it is partially done but will need to revise a bit with CASL integration maybe?

@leecalcote leecalcote modified the milestones: v0.7.0, v0.8.0 Dec 12, 2023
@sandramsc sandramsc added the issue/remind Issue progress check label Jan 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@nebula-aac nebula-aac mentioned this issue Feb 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nebula-aac nebula-aac

Labels
component/ui User Interface framework/react issue/remind Issue progress check issue/willfix This issue will be worked on kind/enhancement Improvement in current feature language/javascript Issues or pull requests that use Javascript or React
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
5 participants
@leecalcote @acald-creator @sandramsc @siddheshJungade @nebula-aac