New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: Relationship for IngressClass and other k8s resources #10355
Merged
MUzairS15
merged 7 commits into
meshery:master
from
RipulHandoo:RipulHandoo/Relationships/IngressClass
Feb 24, 2024
Merged
add: Relationship for IngressClass and other k8s resources #10355
MUzairS15
merged 7 commits into
meshery:master
from
RipulHandoo:RipulHandoo/Relationships/IngressClass
Feb 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
github-actions
bot
added
component/server
area/models
Models, Components, Relationships related changes
labels
Feb 20, 2024
Note: Spreadsheet updated. ✅ |
Looks good to me! |
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Thanks for this, @pandeyshubham03 👍 |
leecalcote
requested changes
Feb 24, 2024
"mutatorRef": [ | ||
["name"] | ||
], | ||
"description": "IngressClass establishes an inventory relationship with Ingress. IngressClass is a resource to provide default class for Ingress. When a IngressClass is dropped on Ingress specification of Ingress will be updated and configure the class of the Ingress controller." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use "dropped". Such phrasing is only applicable to a visual designer interface.
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
MUzairS15
reviewed
Feb 24, 2024
server/meshmodel/kubernetes/relationships/hierarchical_inventory.json
Outdated
Show resolved
Hide resolved
server/meshmodel/kubernetes/relationships/hierarchical_inventory.json
Outdated
Show resolved
Hide resolved
…ry.json Signed-off-by: Mohd Uzair <muzair.shaikh810@gmail.com>
…ry.json Signed-off-by: Mohd Uzair <muzair.shaikh810@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #
Ingress.Class.mp4
Signed commits