Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: Relationship for IngressClass and other k8s resources #10355

Merged

Conversation

RipulHandoo
Copy link
Contributor

@RipulHandoo RipulHandoo commented Feb 20, 2024

Notes for Reviewers

This PR fixes #

  1. Adds relationship for Ingress Class and other k8s resources.
Ingress.Class.mp4

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@github-actions github-actions bot added component/server area/models Models, Components, Relationships related changes labels Feb 20, 2024
@RipulHandoo
Copy link
Contributor Author

Note: Spreadsheet updated. ✅

Copy link

github-actions bot commented Feb 20, 2024

@pandeyshubham03
Copy link
Contributor

Looks good to me!

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@leecalcote
Copy link
Member

Looks good to me!

Thanks for this, @pandeyshubham03 👍

"mutatorRef": [
["name"]
],
"description": "IngressClass establishes an inventory relationship with Ingress. IngressClass is a resource to provide default class for Ingress. When a IngressClass is dropped on Ingress specification of Ingress will be updated and configure the class of the Ingress controller."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use "dropped". Such phrasing is only applicable to a visual designer interface.

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
…ry.json

Signed-off-by: Mohd Uzair <muzair.shaikh810@gmail.com>
…ry.json

Signed-off-by: Mohd Uzair <muzair.shaikh810@gmail.com>
@MUzairS15 MUzairS15 merged commit 8de88af into meshery:master Feb 24, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/models Models, Components, Relationships related changes component/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants