New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: push and pull subcommand for model command #10483
feat: push and pull subcommand for model command #10483
Conversation
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo will you update the slide that covers this behavior in the Meshery Architecture deck? |
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the pull and push logic to MeshKit as they will be used heavily across components.
Can you please add tests for pushing and pulling to public OCI registries?
merge conflict |
@RipulHandoo merge conflict |
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
21e160f
to
82f532b
Compare
A few lint checks are standing in the way, it seems. |
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
ba097b0
to
db80c7a
Compare
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Sure, I can add tests for pushing and pulling models to public OCI registries. However, to properly authenticate and test these functionalities, we'll need access to a username and password. |
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Notes for Reviewers
This PR fixes #
Signed commits