Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: push and pull subcommand for model command #10483

Conversation

RipulHandoo
Copy link
Contributor

@RipulHandoo RipulHandoo commented Mar 3, 2024

Notes for Reviewers

This PR fixes #

  • Implement command to Push models to OCI Registry
  • Implement command to Pull models from OCI Registry
  • Develop test cases to ensure command functionality

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Copy link

github-actions bot commented Mar 3, 2024

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@leecalcote
Copy link
Member

@RipulHandoo will you update the slide that covers this behavior in the Meshery Architecture deck?

@RipulHandoo RipulHandoo changed the title feat: push subcommand for model command feat: push and pull subcommand for model command Mar 8, 2024
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Copy link
Contributor

@MUzairS15 MUzairS15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the pull and push logic to MeshKit as they will be used heavily across components.

Can you please add tests for pushing and pulling to public OCI registries?

mesheryctl/internal/cli/root/system/model.go Outdated Show resolved Hide resolved
mesheryctl/internal/cli/root/system/model.go Outdated Show resolved Hide resolved
mesheryctl/internal/cli/root/system/model.go Outdated Show resolved Hide resolved
mesheryctl/internal/cli/root/system/model.go Outdated Show resolved Hide resolved
@leecalcote
Copy link
Member

merge conflict

@leecalcote
Copy link
Member

@RipulHandoo merge conflict

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo RipulHandoo force-pushed the RipulHandoo/mesheryctl/PushAndPull branch from 21e160f to 82f532b Compare March 29, 2024 21:23
@leecalcote
Copy link
Member

A few lint checks are standing in the way, it seems.

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo RipulHandoo force-pushed the RipulHandoo/mesheryctl/PushAndPull branch from ba097b0 to db80c7a Compare April 5, 2024 08:24
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo
Copy link
Contributor Author

Move the pull and push logic to MeshKit as they will be used heavily across components.

Can you please add tests for pushing and pulling to public OCI registries?

Sure, I can add tests for pushing and pulling models to public OCI registries. However, to properly authenticate and test these functionalities, we'll need access to a username and password.

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@l5io l5io closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mesheryctl CLI for Meshery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants