New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relationship between Adopted Resources with other aws-prometheusservice-controller components. #10494
Conversation
…service-controller components Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
"apiVersion": "core.meshery.io/v1alpha1", | ||
"kind": "Hierarchical", | ||
"metdata": { | ||
"description": "Hierarchical" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "A hierarchical inventory relationship in which the configuration of (parent) component is patched with the configuration of other (child) component. Eg: The configuration of the EnvoyFilter (parent) component is patched with the configuration as received from WASMFilter (child) component."
server/meshmodel/aws-prometheusservice-controller/relationships/hierarchical_inventory.json
Outdated
Show resolved
Hide resolved
server/meshmodel/aws-prometheusservice-controller/relationships/hierarchical_inventory.json
Outdated
Show resolved
Hide resolved
server/meshmodel/aws-prometheusservice-controller/relationships/hierarchical_inventory.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that this relationship is valuable. My understanding is that it might only be valuable to the extent that the user is in a brownfield situation, which is to say that they have already deployed their Pods (in this case). The behavior of the AdoptedResource (which is a resource pervasively available throughout each of the controller projects) is valuable to capture into a Meshery Relationship in-context of melding Visualizer (Operator) and Designer modes. The following is my understanding of the purpose and use of AdoptedResources.
An AdoptedResource in the AWS Controllers for Kubernetes (ACK) project only applies to resources that have been deployed to a running cluster. It does not apply to resources defined solely in a manifest (not yet deployed).
Here's why:
- Interaction with existing resources: The primary function of AdoptedResource is to manage existing AWS resources, not resources defined for future deployment. It achieves this by referencing the already provisioned resource and ensuring its state aligns with your configuration. Manifests, on the other hand, hold definitions for resources to be created, not existing ones.
- Kubernetes API interaction: AdoptedResource interacts with the Kubernetes API to retrieve information about the existing resource and potentially manage its desired state. However, until a resource is deployed to the cluster and registered with the API, there's no information for AdoptedResource to interact with.
Therefore, while AdoptedResource offers a way to integrate existing resources with your Kubernetes cluster, it only takes effect once those resources are deployed and registered within the cluster.
I make note of this to help ensure that we understand when and where this relationship is useful to users, and how this moment in time (day 2 only), serves as a prerequisite that Meshery might need to enforce with the presences of the id.pattern.meshery.io
annotation on the given existing Pod (in this case) resource.
…s/hierarchical_inventory.json Signed-off-by: Lee Calcote <leecalcote@gmail.com>
…s/hierarchical_inventory.json Signed-off-by: Lee Calcote <leecalcote@gmail.com>
server/meshmodel/aws-prometheusservice-controller/relationships/hierarchical_inventory.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Notes for Reviewers
This PR fixes #
1.Relationship between Adopted Resources with other aws-prometheusservice-controller components.
Signed commits