Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consolidate mesheryctl app into pattern #10590

Merged
merged 9 commits into from Mar 25, 2024
Merged

consolidate mesheryctl app into pattern #10590

merged 9 commits into from Mar 25, 2024

Conversation

RipulHandoo
Copy link
Member

Notes for Reviewers

This PR fixes #

  1. Consolidate mesheryctl app into pattern

Signed commits

  • Yes, I signed my commits.

@RipulHandoo
consolidate mesheryctl app into pattern
710bb6e 
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@github-actions github-actions bot added the component/mesheryctl CLI for Meshery label Mar 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2024 •
edited

leecalcote
leecalcote reviewed Mar 20, 2024
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs update?

@leecalcote
Copy link
Member

@Althaf66 comment?

@RipulHandoo
Copy link
Member Author

Docs update?

Mesheryctl spreadsheet?

@leecalcote
Copy link
Member

Docs update?

Mesheryctl spreadsheet?

Yes, please, but also the CLI reference on docs.meshery.io needs updated. Some of the updates are done automatically, while there is still a manual step in this process, that appears to be undocumented here - https://docs.meshery.io/project/contributing/contributing-cli-guide. @alphaX86 and @hexxdump will you please ensure that the manual task of updating the command index / data file is prominently listed in the CLI contributing guide?

@leecalcote
Copy link
Member

Docs updated, @RipulHandoo?

@RipulHandoo
Copy link
Member Author

Docs updated, @RipulHandoo?

Spreadsheet updated.

@leecalcote
Copy link
Member

Great. What about Meshery docs?

@leecalcote
Copy link
Member

Have you gotten information from @alphaX86 on how to update Meshery docs?

@alphaX86 , do we have the Manuel updated instructions listed in the docs?

@alphaX86
Copy link
Member

Have you gotten information from @alphaX86 on how to update Meshery docs?

@alphaX86 , do we have the Manuel updated instructions listed in the docs?

We do have the instructions @leecalcote, I'll update them for better visibility.

@RipulHandoo please follow the instructions from this link: https://docs.meshery.io/project/contributing/contributing-cli#contributing-to-mesheryctl-documentation

@leecalcote
Copy link
Member

Thank you, @alphaX86 💯

alphaX86
alphaX86 requested changes Mar 23, 2024
View reviewed changes
mesheryctl/internal/cli/root/pattern/error.go Outdated Show resolved Hide resolved
mesheryctl/internal/cli/root/pattern/onboard_test.go Outdated Show resolved Hide resolved
mesheryctl/internal/cli/root/root.go Show resolved Hide resolved
@RipulHandoo
fix typo
2665d84 
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo RipulHandoo force-pushed the RipulHandoo/mesheryctl/appToPattern branch from ff6860a to 2665d84 Compare March 23, 2024 17:39
RipulHandoo and others added 4 commits March 24, 2024 18:13
@RipulHandoo
fix
6e7c2c8 
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo
using args func
32844a4 
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@leecalcote
Merge branch 'master' into RipulHandoo/mesheryctl/appToPattern
84e92b2
@leecalcote
Generated docs for new pattern subcommands
c680cad 
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
@github-actions github-actions bot added the area/docs Documentation update needed label Mar 25, 2024
@l5io
Copy link
Collaborator

l5io commented Mar 25, 2024

🚀 Preview for commit c680cad at: https://6601f12aaa4d2d54eacaad15--meshery-docs-preview.netlify.app

@leecalcote
remove old app command docs
37315d0 
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
@leecalcote
refresh copyright notice
7baa882 
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
@leecalcote
swap app and pattern in docs/_data/mesheryctlcommands/cmds.yml
98aacd5 
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
@leecalcote
Copy link
Member

@RipulHandoo what is the difference between mesheryctl pattern apply and mesheryctl pattern onboard?

@leecalcote leecalcote merged commit ba67351 into meshery:master Mar 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexxdump hexxdump hexxdump left review comments

@leecalcote leecalcote leecalcote left review comments

@MUzairS15 MUzairS15 MUzairS15 requested changes

@Althaf66 Althaf66 Awaiting requested review from Althaf66

@alphaX86 alphaX86 Awaiting requested review from alphaX86

Assignees
No one assigned
Labels
area/docs Documentation update needed component/mesheryctl CLI for Meshery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@RipulHandoo @leecalcote @alphaX86 @l5io @hexxdump @MUzairS15