Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix height of registry section #10642

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

sudhanshutech
Copy link
Member

Notes for Reviewers

This PR fixes #9595
Fixes the height in large screens .
Note: Further increasing may affect the small screens with less resolution.

before:
image

after:
image

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
@github-actions github-actions bot added the component/ui User Interface label Mar 29, 2024
Copy link

github-actions bot commented Mar 29, 2024

@sudhanshutech
Copy link
Member Author

can you confirm if it works in safari @Yashsharma1911

Signed-off-by: Sudhanshu Dasgupta <dasguptashivam23@gmail.com>
@leecalcote
Copy link
Member

Are you just randomly guessing at 60vh?

@leecalcote
Copy link
Member

What happens on resize of the browser window?

@sudhanshutech
Copy link
Member Author

sudhanshutech commented Apr 3, 2024

no not randomly, i tested by increasing and decreasing my browser resolution: https://www.awesomescreenshot.com/video/26394224?key=4ea5a1d4d7ad89ab5c00c0998d09ee94

@Yashsharma1911
Copy link
Contributor

Testing

@Yashsharma1911
Copy link
Contributor

Yashsharma1911 commented Apr 3, 2024

When we have big height it does work as expected, also on normal view adding vh like this '73vh', showing scroll bar in whole page, I'll push changes in this PR

@sudhanshutech
Copy link
Member Author

When we have big height it does work as expected, also on normal view adding vh like this '73vh', showing scroll bar in whole page, I'll push changes in this PR

Did you get chance to push that change @Yashsharma1911 ?

@sudhanshutech
Copy link
Member Author

@Yashsharma1911

Copy link

@prerakkumarpatel prerakkumarpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sudhanshutech
Copy link
Member Author

@Yashsharma1911

@leecalcote
Copy link
Member

lgtm

Thanks, @prerakkumarpatel. How do we ensure that the height of this component dynamically resizes on change of browser height, though? Suggestions?

@leecalcote
Copy link
Member

@prerakkumarpatel, @sudhanshutech, have either of you figured this out?

@sudhanshutech
Copy link
Member Author

@prerakkumarpatel, @sudhanshutech, have either of you figured this out?

this pr was completed from my end and no more changes were needed. I did wait for @Yashsharma1911 because he said he might pushing any changes which i was not sure about

@sudhanshutech sudhanshutech merged commit 6dbf9e4 into meshery:master Jun 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Registry tree should be full screen height
4 participants