Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Credentials command #10703

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

feat: Credentials command #10703

wants to merge 30 commits into from

Conversation

singh1203
Copy link
Contributor

@singh1203 singh1203 commented Apr 9, 2024 •
edited

Notes for Reviewers

This PR fixes #10585

  • Implement command to list existing credentials
  • Implement command to create new credentials
  • Implement command to delete existing credentials
  • Implement command to view details of a specific credential
  • Develop test cases to ensure command functionality

Signed commits

  • Yes, I signed my commits.

@singh1203
feat: add credential command to mesheryctl
7df92fc 
Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
@singh1203
feat: add credentials list test file and golden files
aabb85e 
Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
@singh1203
feat: changes to credentials create cmd
50dd241 
Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
@github-actions github-actions bot added area/docs Documentation update needed component/mesheryctl CLI for Meshery labels Apr 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited

@singh1203
Merge branch 'master' into mesheryctl/credentials
9ea9aa2 
Signed-off-by: Saurabh <singh1203.ss@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Apr 9, 2024

🚀 Preview for commit 9ea9aa2 at: https://66155a3a76fcd507b71c10a1--meshery-docs-preview.netlify.app

@vishalvivekm
Copy link
Member

vishalvivekm commented Apr 9, 2024 •
edited

Thank you @singh1203
Let's discuss this on Meshery Dev call, please add this to the agenda items: https://docs.google.com/document/d/1Dg4Uz9rGTuGHmYZwIt47z1j5x3LmnpxD1M1SgypAkQ0/edit

@singh1203
fix golang linting
6e905b7 
Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
@singh1203
Copy link
Contributor Author

Thank you @singh1203 Let's discuss this on Meshery Dev call, please add this to the agenda items: https://docs.google.com/document/d/1Dg4Uz9rGTuGHmYZwIt47z1j5x3LmnpxD1M1SgypAkQ0/edit

Sure.

@singh1203
Update helpers.go
0a9c63b 
Signed-off-by: Saurabh <singh1203.ss@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Apr 9, 2024

🚀 Preview for commit 0a9c63b at: https://66157773858a45093bb808b6--meshery-docs-preview.netlify.app

@hamza-mohd
Copy link
Contributor

There is a failing lint check in MeshKit Error Codes to investigate, @singh1203

@l5io
Copy link
Collaborator

l5io commented Apr 11, 2024

🚀 Preview for commit 520946f at: https://66175ff98b34572f105c29ca--meshery-docs-preview.netlify.app

@l5io
Copy link
Collaborator

l5io commented Apr 11, 2024

🚀 Preview for commit e42ed09 at: https://6617778b8e4b1f3f4dc7f7ab--meshery-docs-preview.netlify.app

@singh1203
Updated golden files for credentials list
782845f 
Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Apr 11, 2024

🚀 Preview for commit 782845f at: https://66177907a5c6bf421b211459--meshery-docs-preview.netlify.app

@RipulHandoo RipulHandoo marked this pull request as ready for review April 11, 2024 16:57
@l5io
Copy link
Collaborator

l5io commented Apr 11, 2024

🚀 Preview for commit 87807da at: https://66181ae39b9d9f009c959ae1--meshery-docs-preview.netlify.app

@singh1203
Made changes as requested
cbea9ea 
Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Apr 12, 2024

🚀 Preview for commit cbea9ea at: https://6619287a4489ec10b69e92bc--meshery-docs-preview.netlify.app

@l5io
Copy link
Collaborator

l5io commented Apr 12, 2024

🚀 Preview for commit 92ec449 at: https://66192b00ee51801785f7dd00--meshery-docs-preview.netlify.app

@singh1203
Refactor argument in mesheryctl credentials commands
337cdc5 
Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Apr 15, 2024

🚀 Preview for commit 337cdc5 at: https://661cfdb2e487e33c56cac50c--meshery-docs-preview.netlify.app

@singh1203
Refactor
4bc5bac 
Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Apr 15, 2024

🚀 Preview for commit 4bc5bac at: https://661cff06740ddc4497de1b14--meshery-docs-preview.netlify.app

@l5io
Copy link
Collaborator

l5io commented Apr 17, 2024

🚀 Preview for commit cdfda50 at: https://661f7c9d9005a6f3220c6013--meshery-docs-preview.netlify.app

@singh1203
Mocking for credential.json in test
a5a6408 
Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Apr 17, 2024

🚀 Preview for commit a5a6408 at: https://662012102b512282d36c4e5f--meshery-docs-preview.netlify.app

@singh1203
modified view credential for directory error
7eb1054 
Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Apr 21, 2024

🚀 Preview for commit 7eb1054 at: https://66250d861dda68a67ac2c2c8--meshery-docs-preview.netlify.app

@l5io
Copy link
Collaborator

l5io commented Apr 21, 2024

🚀 Preview for commit 475db96 at: https://66255319edda6be2c282dff3--meshery-docs-preview.netlify.app

RipulHandoo
RipulHandoo previously approved these changes Apr 22, 2024
View reviewed changes
@singh1203
Merge branch 'master' into mesheryctl/credentials
09513b4 
Signed-off-by: Saurabh <singh1203.ss@gmail.com>
@l5io
Copy link
Collaborator

l5io commented Apr 28, 2024

🚀 Preview for commit 09513b4 at: https://662ded2a4c95ce7e33d21854--meshery-docs-preview.netlify.app

@l5io
Copy link
Collaborator

l5io commented Apr 30, 2024

🚀 Preview for commit cc8a990 at: https://6630fe92dee0141e43056b71--meshery-docs-preview.netlify.app

@l5io
Copy link
Collaborator

l5io commented May 1, 2024

🚀 Preview for commit 77bbd18 at: https://6631dc6834aa698f4762de3d--meshery-docs-preview.netlify.app

@l5io
Copy link
Collaborator

l5io commented May 7, 2024

🚀 Preview for commit 5e26ee0 at: https://6639f303669e3dcbe2315fc7--meshery-docs-preview.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote left review comments

@RipulHandoo RipulHandoo RipulHandoo approved these changes

@MUzairS15 MUzairS15 Awaiting requested review from MUzairS15

Assignees
No one assigned
Labels
area/docs Documentation update needed component/mesheryctl CLI for Meshery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mesheryctl]: New command exp credential
6 participants
@singh1203 @l5io @vishalvivekm @hamza-mohd @RipulHandoo @leecalcote