Meshery UI permissions addition/fix #10728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dragon-slayer875
changed the title
dragon-slayer875
force-pushed
the
master
branch
2 times, most recently
from
68dee0a
to
fe09698
Compare
Yashsharma1911
previously approved these changes
Apr 16, 2024
ui/components/ConfirmationModal.js
Outdated
Comment on lines
392
to
395
| disabled={ | ||
| !CAN(keys.UNDEPLOY_DESIGN.action, keys.UNDEPLOY_DESIGN.subject) || | ||
| (CAN(keys.UNDEPLOY_DESIGN.action, keys.UNDEPLOY_DESIGN.subject) && !disabled) | ||
| } |
There was a problem hiding this comment.
We can simplify this, any reason we should stick with the change you made?
Suggested change
| disabled={ | |
| !CAN(keys.UNDEPLOY_DESIGN.action, keys.UNDEPLOY_DESIGN.subject) || | |
| (CAN(keys.UNDEPLOY_DESIGN.action, keys.UNDEPLOY_DESIGN.subject) && !disabled) | |
| } | |
| disabled={!CAN(keys.UNDEPLOY_DESIGN.action, keys.UNDEPLOY_DESIGN.subject) || !disabled} |
There was a problem hiding this comment.
@Yashsharma1911 I wrote it that way because we need to first check if the person has the permission to do that action or not, and then check if the disabled property (which is dependent on the length of the k8s context.) is true or false.
Your suggestion has the chance to enable the action even if the person doesn't have permission for that action.
There was a problem hiding this comment.
Though I just realised the '!' mark before diabled isn't needed and have updated the PR for the same.
ui/components/ConfirmationModal.js
Outdated
Comment on lines
410
to
413
| disabled={ | ||
| !CAN(keys.DEPLOY_DESIGN.action, keys.DEPLOY_DESIGN.subject) || | ||
| (CAN(keys.DEPLOY_DESIGN.action, keys.DEPLOY_DESIGN.subject) && !disabled) | ||
| } |
Comment on lines
+62
to
+64
| pointerEvents: !CAN(keys.VIEW_CONNECTIONS.action, keys.VIEW_CONNECTIONS.subject) | ||
| ? 'none' | ||
| : 'auto', |
dragon-slayer875
force-pushed
the
master
branch
from
145351e
to
a182771
Compare
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
dragon-slayer875
force-pushed
the
master
branch
from
a182771
to
4697cfc
Compare
Signed-off-by: Rudraksh Tyagi <rudraksh875@gmail.com>
Yashsharma1911
approved these changes
Apr 17, 2024
|
Ohh ho, I missed the pr do not merge label, should we revert this PR? is this contain any breaking change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR adds missing permissions for various actions in -
This also fixes -
Signed commits