Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keys table added #10756

Merged
merged 26 commits into from
May 22, 2024
Merged

Keys table added #10756

merged 26 commits into from
May 22, 2024

Conversation

iArchitSharma
Copy link
Contributor

Notes for Reviewers

xx

Signed commits

  • Yes, I signed my commits.

@iArchitSharma
Keys table added
fcf572b 
Signed-off-by: Archit Sharma <archit8679@gmail.com>
@github-actions github-actions bot added the area/docs Documentation update needed label Apr 22, 2024
@l5io
Copy link
Collaborator

l5io commented Apr 22, 2024

🚀 Preview for commit fcf572b at: https://66261741427b5f728530f75f--meshery-docs-preview.netlify.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited

leecalcote
leecalcote previously approved these changes Apr 25, 2024
View reviewed changes
@leecalcote
Copy link
Member

@iArchitSharma what other pages link to this page? Is it tagged with frontmatter such that it shows up in the main index page? Is is manually added to the TOC?

@iArchitSharma
workflow add
547a80e 
Signed-off-by: Archit Sharma <archit8679@gmail.com>
@github-actions github-actions bot added the area/ci Continuous Integration label Apr 28, 2024
@l5io
Copy link
Collaborator

l5io commented Apr 28, 2024

🚀 Preview for commit 547a80e at: https://662df237fd575284b84ec2f3--meshery-docs-preview.netlify.app

@l5io
Copy link
Collaborator

l5io commented May 4, 2024

🚀 Preview for commit 52cf209 at: https://6635af64c2628297b9e888e5--meshery-docs-preview.netlify.app

ShivamCoder23
ShivamCoder23 reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@ShivamCoder23 ShivamCoder23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats left here @iArchitSharma

@iArchitSharma
updated
2313557 
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@l5io
Copy link
Collaborator

l5io commented May 13, 2024

🚀 Preview for commit 2313557 at: https://6641a82f5f644a6a9d002b26--meshery-docs-preview.netlify.app

@iArchitSharma
workflow update
6816401 
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@iArchitSharma
Merge branch 'master' into permRef
b44e12c
@l5io
Copy link
Collaborator

l5io commented May 13, 2024

🚀 Preview for commit b44e12c at: https://6641ab699af0167171a06fcb--meshery-docs-preview.netlify.app

@iArchitSharma
TOC added
9906e33 
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@iArchitSharma
Copy link
Contributor Author

image
image

@l5io
Copy link
Collaborator

l5io commented May 13, 2024

🚀 Preview for commit 9906e33 at: https://6641b30abcb7ce73bb800be3--meshery-docs-preview.netlify.app

@iArchitSharma
Copy link
Contributor Author

@ShivamCoder23 its complete now waiting for review

@l5io
Copy link
Collaborator

l5io commented May 15, 2024

🚀 Preview for commit 9e55af3 at: https://6644b7666e477b158a977fba--meshery-docs-preview.netlify.app

leecalcote
leecalcote previously requested changes May 16, 2024
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the SQL statements included?
Screenshot 2024-05-16 at 10 36 31 AM

@iArchitSharma
update final
8f258b2 
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@iArchitSharma
Copy link
Contributor Author

@leecalcote i forgot to push my last commit, it ready for merge now!

@l5io
Copy link
Collaborator

l5io commented May 16, 2024

🚀 Preview for commit ca61bbe at: https://664643af67e6b51aa8a6e03b--meshery-docs-preview.netlify.app

@iArchitSharma
final
44288aa 
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@l5io
Copy link
Collaborator

l5io commented May 16, 2024

🚀 Preview for commit 44288aa at: https://66464705ab96fe23c589657b--meshery-docs-preview.netlify.app

@iArchitSharma
code reformat
6aafe03 
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@l5io
Copy link
Collaborator

l5io commented May 16, 2024

🚀 Preview for commit 6aafe03 at: https://66464823453c371f1b2b64cc--meshery-docs-preview.netlify.app

@iArchitSharma
inserted column removed
3674061 
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@iArchitSharma
Remove Gemfile
e9b46ac
@iArchitSharma
Revert "inserted column removed"
c87aea9
@iArchitSharma
final
c4de26f 
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@l5io
Copy link
Collaborator

l5io commented May 16, 2024

🚀 Preview for commit c87aea9 at: https://664667a456a651008508f68f--meshery-docs-preview.netlify.app

@l5io
Copy link
Collaborator

l5io commented May 16, 2024

🚀 Preview for commit c4de26f at: https://6646685a7c57ca04f4ac9463--meshery-docs-preview.netlify.app

@dragon-slayer875
Copy link
Contributor

@iArchitSharma Maybe the table contents can be scrolled through horizontally too when in mobile mode?

image

@l5io
Copy link
Collaborator

l5io commented May 22, 2024

🚀 Preview for commit a7b00ce at: https://664d78095caf3d9341e24f76--meshery-docs-preview.netlify.app

@iArchitSharma
Responsive
e610521 
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@iArchitSharma
Merge branch 'permRef' of https://github.com/iArchitSharma/meshery in…
012d107 
…to permRef
@l5io
Copy link
Collaborator

l5io commented May 22, 2024

🚀 Preview for commit 012d107 at: https://664db6c1f06a64cb72ef27fd--meshery-docs-preview.netlify.app

@iArchitSharma
update
73e81b6 
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@l5io
Copy link
Collaborator

l5io commented May 22, 2024

🚀 Preview for commit 73e81b6 at: https://664ddea60ea540f87e152002--meshery-docs-preview.netlify.app

@iArchitSharma
Keychain ID to Keychain name
1a0e717 
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@l5io
Copy link
Collaborator

l5io commented May 22, 2024

🚀 Preview for commit 1a0e717 at: https://664de201f06a64fbaaef2854--meshery-docs-preview.netlify.app

@iArchitSharma
final
9894c6b 
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@iArchitSharma
Merge branch 'permRef' of https://github.com/iArchitSharma/meshery in…
de60ac3 
…to permRef
@iArchitSharma
final
b17035a 
Signed-off-by: Archit Sharma <74408634+iArchitSharma@users.noreply.github.com>
@l5io
Copy link
Collaborator

l5io commented May 22, 2024

🚀 Preview for commit b17035a at: https://664deca7d0044e0463a7c957--meshery-docs-preview.netlify.app

Yashsharma1911
Yashsharma1911 approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@Yashsharma1911 Yashsharma1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, two items remaining

  1. Categories keys table similar to docs.layer5.io
  2. Allow to show key id if user want to see, bydefault hide it

you can take care of these items in separate PR

@Yashsharma1911 Yashsharma1911 dismissed leecalcote’s stale review May 22, 2024 13:05

SQL col is removed, it was unnecessary

@Yashsharma1911 Yashsharma1911 merged commit 9dc6c36 into meshery:master May 22, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShivamCoder23 ShivamCoder23 ShivamCoder23 left review comments

@Yashsharma1911 Yashsharma1911 Yashsharma1911 approved these changes

@leecalcote leecalcote Awaiting requested review from leecalcote

@dragon-slayer875 dragon-slayer875 Awaiting requested review from dragon-slayer875

Assignees
No one assigned
Labels
area/ci Continuous Integration area/docs Documentation update needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@iArchitSharma @l5io @leecalcote @dragon-slayer875 @Yashsharma1911 @ShivamCoder23