Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server] Add support to fetch connection by id. #10801

Merged
merged 7 commits into from May 1, 2024

Conversation

MUzairS15
Copy link
Contributor

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
Copy link

github-actions bot commented Apr 27, 2024

@lekaf974
Copy link
Contributor

@MUzairS15 something wrong with meshkit error test related to mesheryctl does your branch up-to-date ? or perhaps not related

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syncing with HEAD...

@lekaf974
Copy link
Contributor

@leecalcote seeing you trying to fix the issue by syncing to master but the test meshery error code is failing since this last week https://github.com/meshery/meshery/actions/workflows/error-codes-updater.yaml?page=2 after a PR merge

@lekaf974
Copy link
Contributor

#10818 should fix Meshery Error Codes Utility Runner

@leecalcote
Copy link
Member

Oh, I see. This is good. 👍 Let’s give it another sync…

Copy link
Contributor

@lekaf974 lekaf974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leecalcote leecalcote merged commit 7c23edb into meshery:master May 1, 2024
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants