Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix .github/labeler.yml upgrade to actions/labeler@v5 problem #10817

Merged
merged 1 commit into from
May 6, 2024
Merged

[CI] Fix .github/labeler.yml upgrade to actions/labeler@v5 problem #10817

merged 1 commit into from
May 6, 2024

Conversation

tico88612
Copy link
Contributor

@tico88612 tico88612 commented Apr 30, 2024 •
edited

Notes for Reviewers

This PR fixes #10816

Signed commits

  • Yes, I signed my commits.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited

@tico88612 tico88612 marked this pull request as draft April 30, 2024 00:45
@tico88612 tico88612 marked this pull request as ready for review April 30, 2024 00:52
@github-actions github-actions bot added the area/ci Continuous Integration label Apr 30, 2024
@leecalcote
Copy link
Member

Thank you, @tico88612! 🙌

singh1203
singh1203 approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@singh1203 singh1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I think we should keep - pull_request_target because ultimately target is base branch, otherwise LGTM.

lekaf974
lekaf974 approved these changes May 4, 2024
View reviewed changes
Copy link
Contributor

@lekaf974 lekaf974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tico88612
Fix: .github/labeler.yml upgrade to v5 problem
ec754a7 
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
@leecalcote leecalcote merged commit 0c54e67 into meshery:master May 6, 2024
4 checks passed
@tico88612 tico88612 deleted the chore/labeler branch May 6, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lekaf974 lekaf974 lekaf974 approved these changes

@singh1203 singh1203 singh1203 approved these changes

@deepak4566 deepak4566 Awaiting requested review from deepak4566

Assignees
No one assigned
Labels
area/ci Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Upgrade to actions/labeler@v5 requires updates to .github/labeler.yml
4 participants
@tico88612 @leecalcote @lekaf974 @singh1203