-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete stuck pods in valid_namespaces #10904
Conversation
Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’ll work! 🤠
So this will just list all the pods that are not currently running or being created right? @MUzairS15 |
@cpepper96, good eye. I don't know that this PR takes us to conclusion with a deletion of unwanted Pods.... |
Yes |
in that case, how is this helpful? |
The PR is for deleting stuck/crashing pods in namespaces we don’t delete (valid namespaces) hence freeing up resources. |
For resources (or pods) in other namespaces we are deleting the entire namespace hence covered. |
I feel like I'm missing something here 😆 @MUzairS15 are you planning on adding to this script to delete the stuck pods or just list them? Sidenote, can we just wipe the whole |
Signed-off-by: Mohd Uzair <muzair.shaikh810@gmail.com>
Thanks for pointing out. I was testing if the command is able to select required pods correctly and later forgot to replace |
Yes we can, but still there can be stale pods in other namespaces. |
@MUzairS15 should this be marked as draft or work-in-progress? |
It is completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Notes for Reviewers
This PR fixes #
Signed commits