-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Snackbar title on toggle of extensions #10927
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: NAMANIND <namanrai309@gmail.com>
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack. |
Hey @NAMANIND , let's discuss this on today's Meshery Dev meeting at 7:30 PM IST. I am adding this as an agenda item. Please Join https://meet.layer5.io/meshery if you are available during the meet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any screenshot or recording @NAMANIND ?
Hey @sudhanshutech here is the video PreviouslyWhen enabling or disabling an extension, the message "Adapter processing" was displayed as a popup. CurrentlyUpon enabling or disabling an extension, the name of the extension is properly displayed in the popup message, along with the appropriate "enable" or "disable" text. Extensions._.Meshery.-.Google.Chrome.2024-05-20.16-57-43.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A screenshot/recording depicitng the behaviour will be appreciated.
Oh you already did, nice.
@@ -58,19 +58,22 @@ const Adapters = ({ updateProgress, classes }) => { | |||
const handleAdapterDeployment = (payload, msg, selectedAdapter, adapterId) => { | |||
updateProgress({ showProgress: true }); | |||
|
|||
const isEnableAction = payload.status === 'ENABLED'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define (if it does not exist already) a constant inside constants.js and use that here as well on line 74 (you would have to use toLowerCase() or toUpperCase() depending on what you define the value for that constant)
More precisely, |
@NAMANIND any further progress? |
Notes for Reviewers
This PR fixes #10514
Signed commits