[mesheryctl] Removal of the `onboard` Sub-command from `Mesheryctl Pattern` Command #10929

singh1203 · 2024-05-11T15:15:49Z

Notes for Reviewers

This PR fixes #10886

Signed commits

Yes, I signed my commits.

github-actions · 2024-05-11T15:18:37Z

Understanding Meshery Relationships

leecalcote

@singh1203 will you list the various test scenarios that you've tried and their results?

singh1203 · 2024-05-14T16:30:02Z

@singh1203 will you list the various test scenarios that you've tried and their results?

Currently haven't tested various scenarios, but will prioritize doing so ASAP and exploring different tests I can run.

leecalcote · 2024-05-16T19:44:49Z

Any scenarios and results to report, @singh1203?

singh1203 · 2024-05-17T07:21:53Z

Any scenarios and results to report, @singh1203?

Certainly! Here is a list of the various test scenarios and their results for the mesheryctl pattern command:

`mesheryctl pattern apply`

Applying with ID
- Result: Failed
- Issue: No pattern found with the given name or ID.
- Error Message: "Fetching patterns... No Pattern found with the given name or ID."
Applying with file path
- Result: Successful
- Issue: Pattern is created but not deployed.
- Error Message: "Applying pattern Simple Kubernetes Pod. Response Status Code 500, possibly Server error."
Documentation issues
- Issue: Missing proper documentation for the command syntax (e.g., mesheryctl pattern apply [patternID]).

`mesheryctl pattern import`

Importing from local file
- Result: Successful
- Issue: None
Importing from URL
- Result: Successful
- Issue: None
- Opened issue [mesheryctl] Issue Converting Helm Chart to Kubernetes Manifest when Importing Design via URL #10960

`mesheryctl pattern delete`

Deleting with patternID
- Result: Successful
- Issue: None
Deleting with file path
- Result: Failed
- Issue: Response Status Code 500, possibly Server error.
- Error Message: "Unable to create a response from request. Response Status Code 500, possibly Server error."
Deleting with URL
- Result: Failed
- Issue: Unclear what is meant by URL in the command syntax (mesheryctl pattern delete {URL to patternfile}).

`mesheryctl pattern offboard`

URL-based pattern deletion
- Result: Not implemented
- Issue: Lack of URL-based pattern deletion in the implementation.
Redundancy with delete sub-command
- Issue: There is no significant difference between the offboard and delete sub-commands, suggesting the offboard sub-command could be removed.

`mesheryctl pattern view`

Viewing patterns
- Result: Successful
- Issue: Sometimes the response is too large to be fully viewed in the CLI.

`mesheryctl pattern list`

Listing patterns
- Result: Successful
- Issue: None

leecalcote · 2024-05-23T10:47:34Z

@singh1203, good progress. Send word when the tests are passing.

codecov · 2024-06-02T09:37:23Z

Codecov Report

Attention: Patch coverage is 2.85714% with 34 lines in your changes missing coverage. Please review.

Project coverage is 8.86%. Comparing base (0bbdd7f) to head (78e1a56).
Report is 186 commits behind head on master.

❗ Current head 78e1a56 differs from pull request most recent head 21c7d22

Please upload reports for the commit 21c7d22 to get more accurate results.

Files	Patch %	Lines
mesheryctl/internal/cli/root/pattern/import.go	0.00%	34 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10929      +/-   ##
==========================================
- Coverage    9.11%    8.86%   -0.25%     
==========================================
  Files         146      145       -1     
  Lines       19303    19144     -159     
==========================================
- Hits         1760     1698      -62     
+ Misses      17241    17163      -78     
+ Partials      302      283      -19

Flag	Coverage Δ
unittests	`8.86% <2.85%> (-0.25%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

singh1203 · 2024-06-04T18:43:44Z

@leecalcote Implementing design pattern with pattern subcommands, but encountering server error (500) every time. I've Updated scenario condition above, but error persists.
Here is the issue #11110 for it.

leecalcote · 2024-06-04T19:22:59Z

@leecalcote Implementing design pattern with pattern subcommands, but encountering server error (500) every time. I've Updated scenario condition above, but error persists. Here is the issue #11110 for it.

Will you confirm that you can successfully deploy this pattern via Meshery UI?

leecalcote · 2024-06-04T19:23:48Z

If not, trying using a simple design that you are confident has no deployment issues.

singh1203 · 2024-06-05T09:19:09Z

@leecalcote Implementing design pattern with pattern subcommands, but encountering server error (500) every time. I've Updated scenario condition above, but error persists. Here is the issue #11110 for it.

Will you confirm that you can successfully deploy this pattern via Meshery UI?

Pattern_clip.mp4

I hope this clip addresses your question!

singh1203 · 2024-06-16T14:05:03Z

@lekaf974 Surely your eyes can see imperfections here.

lekaf974

Missing documentation update in docs/_data/mesheryctlcommands/cmds.yml

mesheryctl/internal/cli/root/pattern/apply.go

mesheryctl/internal/cli/root/pattern/delete.go

lekaf974 · 2024-06-16T14:33:07Z

Example in --help needs to be updated

~ mesheryctl]$ ./mesheryctl pattern delete --help
delete pattern file will trigger deletion of the pattern file

Usage:
  mesheryctl pattern delete [flags]

Examples:

// delete a pattern file
mesheryctl pattern delete [file | URL]
	

Flags:
  -f, --file string   Path to pattern file
  -h, --help          help for delete

Global Flags:
      --config string   path to config file (default "/home/matthieu/.meshery/config.yaml")
  -t, --token string    Path to token file default from current context
  -v, --verbose         verbose output

lekaf974 · 2024-06-16T14:51:47Z

Looks Argurment validation is missing on delete sub-command

[~ mesheryctl]$ ./mesheryctl pattern delete
Access to this resource is unauthorized.
Access to this resource is unauthorized.
delete without any args/flags is making 2 calls to the backend

Could add a check to validate name args or --file flag is given following this example

meshery/mesheryctl/internal/cli/root/connections/delete.go

Line 47 in 789bd25

Args: func(_ *cobra.Command, args []string) error {

l5io · 2024-06-16T17:19:28Z

🚀 Preview for commit dddc459 at: https://666f1e8130c66017f86b38af--meshery-docs-preview.netlify.app

lekaf974 · 2024-06-17T03:12:31Z

mesheryctl/internal/cli/root/pattern/apply.go

+		}
+		return nil
+	},
+	Args: cobra.MinimumNArgs(0),


Should use same implementation for Args that you made in the delete sub command for UX consistency

l5io · 2024-06-19T08:50:17Z

🚀 Preview for commit bc5f560 at: https://66729bac6a08c6e206eb4dc6--meshery-docs-preview.netlify.app

leecalcote · 2024-06-28T17:27:57Z

@singh1203 all comments resolved?

l5io · 2024-06-29T04:24:30Z

🚀 Preview for commit 1ecb940 at: https://667f8c5acaa5b7cec5f0daed--meshery-docs-preview.netlify.app

singh1203 · 2024-06-29T06:47:04Z

@singh1203 all comments resolved?

Yes, almost all of it is now working regarding your suggestion of confirming a particular environment before applying and deleting any pattern(design).

Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>

l5io · 2024-06-30T17:51:34Z

🚀 Preview for commit 21c7d22 at: https://66819b09fab9d05c14b7b189--meshery-docs-preview.netlify.app

github-actions bot added the component/mesheryctl CLI for Meshery label May 11, 2024

singh1203 marked this pull request as ready for review May 11, 2024 15:24

leecalcote requested review from lekaf974 and alphaX86 May 13, 2024 22:15

leecalcote reviewed May 14, 2024

View reviewed changes

singh1203 force-pushed the mesheryctl/pattern branch from 84cf437 to a2d3020 Compare June 4, 2024 17:32

singh1203 mentioned this pull request Jun 5, 2024

[Server] Meshery server error (500) with ErrCompConfigPairsCode-1073 during deployment #11110

Open

singh1203 force-pushed the mesheryctl/pattern branch from a2d3020 to 78e1a56 Compare June 6, 2024 08:17

singh1203 force-pushed the mesheryctl/pattern branch from 5616aee to a74f36f Compare June 16, 2024 07:33

lekaf974 suggested changes Jun 16, 2024

View reviewed changes

mesheryctl/internal/cli/root/pattern/apply.go Outdated Show resolved Hide resolved

lekaf974 reviewed Jun 16, 2024

View reviewed changes

mesheryctl/internal/cli/root/pattern/delete.go Show resolved Hide resolved

github-actions bot added the area/docs Documentation update needed label Jun 16, 2024

singh1203 force-pushed the mesheryctl/pattern branch from cc44e47 to dddc459 Compare June 16, 2024 17:16

lekaf974 reviewed Jun 17, 2024

View reviewed changes

singh1203 added 7 commits June 30, 2024 23:18

Refactor: (meshery#10886)Pattern import and onboard command

a5cb125

Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>

Refactor pattern apply and delete commands

b406856

Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>

fix: delete pattern golang lint error

b758959

Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>

fix: add mock context to pattern apply test

d66784d

Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>

refactor: context func and pattern apply and delete

b8807a7

Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>

fix args field in delete pattern

080f969

Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>

refactor: delete subcommand and test file for pattern

21c7d22

Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>

singh1203 force-pushed the mesheryctl/pattern branch from 7ba1cd9 to 21c7d22 Compare June 30, 2024 17:48

leecalcote requested a review from Jougan-0 July 1, 2024 21:39

leecalcote approved these changes Jul 1, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[mesheryctl] Removal of the `onboard` Sub-command from `Mesheryctl Pattern` Command #10929

[mesheryctl] Removal of the `onboard` Sub-command from `Mesheryctl Pattern` Command #10929

singh1203 commented May 11, 2024

github-actions bot commented May 11, 2024 •

edited

Loading

leecalcote left a comment

singh1203 commented May 14, 2024

leecalcote commented May 16, 2024

singh1203 commented May 17, 2024 •

edited

Loading

leecalcote commented May 23, 2024

codecov bot commented Jun 2, 2024 •

edited

Loading

singh1203 commented Jun 4, 2024 •

edited

Loading

leecalcote commented Jun 4, 2024

leecalcote commented Jun 4, 2024

singh1203 commented Jun 5, 2024

singh1203 commented Jun 16, 2024

lekaf974 left a comment

lekaf974 commented Jun 16, 2024

lekaf974 commented Jun 16, 2024

l5io commented Jun 16, 2024

lekaf974 Jun 17, 2024 •

edited

Loading

l5io commented Jun 19, 2024

leecalcote commented Jun 28, 2024

l5io commented Jun 29, 2024

singh1203 commented Jun 29, 2024

l5io commented Jun 30, 2024

[mesheryctl] Removal of the onboard Sub-command from Mesheryctl Pattern Command #10929

Are you sure you want to change the base?

[mesheryctl] Removal of the onboard Sub-command from Mesheryctl Pattern Command #10929

Conversation

singh1203 commented May 11, 2024

github-actions bot commented May 11, 2024 • edited Loading

leecalcote left a comment

Choose a reason for hiding this comment

singh1203 commented May 14, 2024

leecalcote commented May 16, 2024

singh1203 commented May 17, 2024 • edited Loading

mesheryctl pattern apply

mesheryctl pattern import

mesheryctl pattern delete

mesheryctl pattern offboard

mesheryctl pattern view

mesheryctl pattern list

leecalcote commented May 23, 2024

codecov bot commented Jun 2, 2024 • edited Loading

Codecov Report

singh1203 commented Jun 4, 2024 • edited Loading

leecalcote commented Jun 4, 2024

leecalcote commented Jun 4, 2024

singh1203 commented Jun 5, 2024

singh1203 commented Jun 16, 2024

lekaf974 left a comment

Choose a reason for hiding this comment

lekaf974 commented Jun 16, 2024

lekaf974 commented Jun 16, 2024

l5io commented Jun 16, 2024

lekaf974 Jun 17, 2024 • edited Loading

Choose a reason for hiding this comment

l5io commented Jun 19, 2024

leecalcote commented Jun 28, 2024

l5io commented Jun 29, 2024

singh1203 commented Jun 29, 2024

l5io commented Jun 30, 2024

[mesheryctl] Removal of the `onboard` Sub-command from `Mesheryctl Pattern` Command #10929

[mesheryctl] Removal of the `onboard` Sub-command from `Mesheryctl Pattern` Command #10929

github-actions bot commented May 11, 2024 •

edited

Loading

singh1203 commented May 17, 2024 •

edited

Loading

`mesheryctl pattern apply`

`mesheryctl pattern import`

`mesheryctl pattern delete`

`mesheryctl pattern offboard`

`mesheryctl pattern view`

`mesheryctl pattern list`

codecov bot commented Jun 2, 2024 •

edited

Loading

singh1203 commented Jun 4, 2024 •

edited

Loading

lekaf974 Jun 17, 2024 •

edited

Loading